Bug 173228 - [JSC] Avoid code bloating for iteration if block does not have "break"
Summary: [JSC] Avoid code bloating for iteration if block does not have "break"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Yusuke Suzuki
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-06-10 11:19 PDT by Yusuke Suzuki
Modified: 2017-08-17 05:16 PDT (History)
8 users (show)

See Also:

Attachments
Patch (10.51 KB, patch)
2017-08-16 02:39 PDT, Yusuke Suzuki 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yusuke Suzuki 2017-06-10 11:19:47 PDT 
for-of iteration emits code path for break. But we can easily ensure that the given for-of does not have "break".
If we ensure that the given block does not have "break" we should not emit this code path.
Comment 1 Yusuke Suzuki 2017-08-16 02:39:39 PDT 
Created attachment 318245 [details]
Patch
Comment 2 Keith Miller 2017-08-16 13:16:43 PDT 
Comment on attachment 318245 [details]
Patch

r=me.
Comment 3 Yusuke Suzuki 2017-08-17 04:45:48 PDT 
Comment on attachment 318245 [details]
Patch

Thanks!
Comment 4 WebKit Commit Bot 2017-08-17 05:15:52 PDT 
Comment on attachment 318245 [details]
Patch

Clearing flags on attachment: 318245

Committed r220852: <http://trac.webkit.org/changeset/220852>
Comment 5 WebKit Commit Bot 2017-08-17 05:15:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-08-17 05:16:57 PDT 
<rdar://problem/33938501>