Bug 173225

Summary: [iOS DnD] WebItemProviderPasteboard should call its completion block immediately after a synchronous load
Product: WebKit Reporter: Wenson Hsieh <wenson_hsieh>
Component: WebCore Misc.Assignee: Wenson Hsieh <wenson_hsieh>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, bdakin, commit-queue, megan_gardner, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Add rdar link to ChangeLogs none

Wenson Hsieh
Reported 2017-06-10 03:49:23 PDT
If WebItemProviderPasteboard finishes synchronous loading via -doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:, it should immediately invoke its completion block instead of waiting until the next runloop. This adjusts for current changes on ToT UIKit that break text drop animations; since previewForLiftingItem: will soon be invoked immediately after performDrop:, we will need to call the item provider load completion block within the same runloop as the rest of the performDrop flow, otherwise the preview will be requested before text indicator data is available.
Attachments
Patch (7.39 KB, patch)
2017-06-10 03:59 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Add rdar link to ChangeLogs (7.46 KB, patch)
2017-06-12 08:57 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2017-06-10 03:59:20 PDT
Created attachment 312569 [details] Patch
Wenson Hsieh
Comment 2 2017-06-12 08:36:46 PDT
<rdar://problem/32713144>
Wenson Hsieh
Comment 3 2017-06-12 08:57:26 PDT
Created attachment 312668 [details] Add rdar link to ChangeLogs
WebKit Commit Bot
Comment 4 2017-06-12 12:34:40 PDT
Comment on attachment 312668 [details] Add rdar link to ChangeLogs Clearing flags on attachment: 312668 Committed r218125: <http://trac.webkit.org/changeset/218125>
WebKit Commit Bot
Comment 5 2017-06-12 12:34:42 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.