Summary: | [Curl] Use SynchronousLoaderClient for platformLoadResourceSynchronously | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Basuke Suzuki <Basuke.Suzuki> | ||||||
Component: | WebCore Misc. | Assignee: | Basuke Suzuki <Basuke.Suzuki> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | achristensen, Basuke.Suzuki, bfulgham, buildbot, commit-queue, don.olmstead, pvollan | ||||||
Priority: | P2 | ||||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 117300 | ||||||||
Attachments: |
|
Description
Basuke Suzuki
2017-06-09 17:18:21 PDT
Created attachment 312681 [details]
Patch
Attachment 312681 [details] did not pass style-queue:
ERROR: Source/WebCore/platform/network/curl/SynchronousLoaderClientCurl.cpp:30: You should not add a blank line before implementation file's own header. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 312681 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312681&action=review Seems like a step in the right direction to match other ports. Could you use Tools/Scripts/prepare-ChangeLog to add a ChangeLog entry? > Source/WebCore/platform/network/curl/ResourceHandleCurl.cpp:130 > + SynchronousLoaderClient client; > + RefPtr<ResourceHandle> handle = adoptRef(new ResourceHandle(context, request, &client, false, false)); > + if (!handle) > + return; null check isn't needed after new in WebKit. In fact, you could do Ref<ResourceHandle> handle = adoptRef(*new ResourceHandle(...)) Yeah, I'm working on it. Still figuring out which tool is right for what I want to. Created attachment 312685 [details]
Patch
Comment on attachment 312685 [details] Patch Clearing flags on attachment: 312685 Committed r218142: <http://trac.webkit.org/changeset/218142> All reviewed patches have been landed. Closing bug. |