Bug 173168

Summary: Avoid some ref counting churn in WebResourceLoadStatisticsStore
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, beidson, bfulgham, commit-queue, darin
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 173172    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2017-06-09 10:41:00 PDT
Avoid some ref counting churn in WebResourceLoadStatisticsStore.
Attachments
Patch (4.75 KB, patch)
2017-06-09 10:43 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.76 KB, patch)
2017-06-09 10:52 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (4.44 KB, patch)
2017-06-09 10:58 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.41 KB, patch)
2017-06-09 11:08 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2017-06-09 10:43:20 PDT
Created attachment 312455 [details] Patch
Chris Dumez
Comment 2 2017-06-09 10:52:30 PDT
Created attachment 312456 [details] Patch
Chris Dumez
Comment 3 2017-06-09 10:58:17 PDT
Created attachment 312457 [details] Patch
Chris Dumez
Comment 4 2017-06-09 11:08:51 PDT
Created attachment 312460 [details] Patch
Chris Dumez
Comment 5 2017-06-09 11:09:24 PDT
Comment on attachment 312460 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312460&action=review > Source/WebKit2/UIProcess/WebResourceLoadStatisticsStore.cpp:122 > + WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores(dataTypesToRemove, WTFMove(prevalentResourceDomains), notifyPages, [this, protectedThis = WTFMove(protectedThis)](Vector<String> domainsWithDeletedWebsiteData) mutable { This was failing to protect |this|.
Brent Fulgham
Comment 6 2017-06-09 11:13:44 PDT
Comment on attachment 312460 [details] Patch r=me
Chris Dumez
Comment 7 2017-06-09 11:32:12 PDT
Comment on attachment 312460 [details] Patch Clearing flags on attachment: 312460 Committed r218002: <http://trac.webkit.org/changeset/218002>
Chris Dumez
Comment 8 2017-06-09 11:32:14 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.