Bug 173151

Summary: [GTK] Use API::GeolocationProvider in WebKitGeolocationProvider
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 173150    
Bug Blocks:    
Attachments:
Description Flags
Patch zan: review+

Description Carlos Garcia Campos 2017-06-09 04:25:05 PDT 
Instead of the C API.
Comment 1 Carlos Garcia Campos 2017-06-09 04:27:51 PDT 
Created attachment 312425 [details]
Patch
Comment 2 Build Bot 2017-06-09 04:30:20 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2017-06-13 03:23:33 PDT 
Comment on attachment 312425 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312425&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.cpp:35
>  #if ENABLE(GEOLOCATION)

These normally go after the "config.h" and main header inclusion.

> Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.cpp:95
> +} // namespace WebKit
> +
>  #endif // ENABLE(GEOLOCATION)

Here the curly brace closing the namespace is inside the ENABLE(GEOLOCATION) guard, while the initial namespace statement is outside it.
Comment 4 Carlos Garcia Campos 2017-06-13 03:35:06 PDT 
Committed r218173: <http://trac.webkit.org/changeset/218173>