Bug 173140

Summary: [GTK] Remove WKFullScreenClientGtk
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Description Carlos Garcia Campos 2017-06-09 01:08:51 PDT 
It's only used internally in the GTK+ API and only making things more complicated.
Comment 1 Carlos Garcia Campos 2017-06-09 01:12:19 PDT 
Created attachment 312407 [details]
Patch
Comment 2 Michael Catanzaro 2017-06-09 07:29:48 PDT 
Comment on attachment 312407 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312407&action=review

> Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:311
> +    if (WEBKIT_IS_WEB_VIEW(m_viewWidget))
> +        webkitWebViewEnterFullScreen(WEBKIT_WEB_VIEW(m_viewWidget));
> +    else
> +        webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget));

What... what could be a WebKitWebViewBase but not a WebKitWebView...?
Comment 3 Carlos Garcia Campos 2017-06-10 01:21:33 PDT 
(In reply to Michael Catanzaro from comment #2)
> Comment on attachment 312407 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=312407&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/PageClientImpl.cpp:311
> > +    if (WEBKIT_IS_WEB_VIEW(m_viewWidget))
> > +        webkitWebViewEnterFullScreen(WEBKIT_WEB_VIEW(m_viewWidget));
> > +    else
> > +        webkitWebViewBaseEnterFullScreen(WEBKIT_WEB_VIEW_BASE(m_viewWidget));
> 
> What... what could be a WebKitWebViewBase but not a WebKitWebView...?

C API WKView, that's why we have WebKitWebViewBase. It's used by WTR and C API unit tests.
Comment 4 Carlos Garcia Campos 2017-06-10 23:30:23 PDT 
Committed r218064: <http://trac.webkit.org/changeset/218064>