Bug 173098

Summary: [GTK] Use API::FormClient instead of the C API in WebKitFormClient
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2017-06-08 06:34:38 PDT
ssia
Attachments
Patch (9.91 KB, patch)
2017-06-08 06:38 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-08 06:38:13 PDT
Created attachment 312301 [details] Patch
Build Bot
Comment 2 2017-06-08 06:41:18 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Zan Dobersek
Comment 3 2017-06-08 08:27:21 PDT
Comment on attachment 312301 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312301&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitFormClient.cpp:47 > + WebKitWebView* m_webView { nullptr }; Same here -- this is assigned in the constructor, so no need to null it out here.
Carlos Garcia Campos
Comment 4 2017-06-08 22:26:52 PDT
Committed r217963: <http://trac.webkit.org/changeset/217963>
Note You need to log in before you can comment on or make changes to this bug.