Bug 173098

Summary:

[GTK] Use API::FormClient instead of the C API in WebKitFormClient

Product:

WebKit

Reporter:

Carlos Garcia Campos <cgarcia>

Component:

WebKitGTK

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan

Priority:

Keywords:

Gtk

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	zan: review+

Description Carlos Garcia Campos 2017-06-08 06:34:38 PDT

ssia

Comment 1 Carlos Garcia Campos 2017-06-08 06:38:13 PDT

Created attachment 312301 [details]
Patch

Comment 2 Build Bot 2017-06-08 06:41:18 PDT

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

Comment 3 Zan Dobersek 2017-06-08 08:27:21 PDT

Comment on attachment 312301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312301&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitFormClient.cpp:47
> +    WebKitWebView* m_webView { nullptr };

Same here -- this is assigned in the constructor, so no need to null it out here.

Comment 4 Carlos Garcia Campos 2017-06-08 22:26:52 PDT

Committed r217963: <http://trac.webkit.org/changeset/217963>