Bug 173098 - [GTK] Use API::FormClient instead of the C API in WebKitFormClient
Summary: [GTK] Use API::FormClient instead of the C API in WebKitFormClient
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2017-06-08 06:34 PDT by Carlos Garcia Campos
Modified: 2017-06-08 22:26 PDT (History)
6 users (show)

See Also:

Patch (9.91 KB, patch)
2017-06-08 06:38 PDT, Carlos Garcia Campos
zan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-08 06:34:38 PDT
Comment 1 Carlos Garcia Campos 2017-06-08 06:38:13 PDT
Created attachment 312301 [details]
Comment 2 Build Bot 2017-06-08 06:41:18 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2017-06-08 08:27:21 PDT
Comment on attachment 312301 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=312301&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitFormClient.cpp:47
> +    WebKitWebView* m_webView { nullptr };

Same here -- this is assigned in the constructor, so no need to null it out here.
Comment 4 Carlos Garcia Campos 2017-06-08 22:26:52 PDT
Committed r217963: <http://trac.webkit.org/changeset/217963>