Summary: | [GTK] Use API::Findclient instead of the C API in WebKitFindController | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Carlos Garcia Campos
2017-06-08 05:19:43 PDT
Created attachment 312294 [details]
Patch
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Comment on attachment 312294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312294&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp:133 > + WebKitFindController* m_findController { nullptr }; We don't have to initialize this to nullptr here since the constructor initializes it anyway. Committed r217961: <http://trac.webkit.org/changeset/217961> |