Bug 173095

Summary: [GTK] Use API::Findclient instead of the C API in WebKitFindController
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, bugs-noreply, buildbot, gustavo, mcatanzaro, zan
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch zan: review+

Carlos Garcia Campos
Reported 2017-06-08 05:19:43 PDT
ssia
Attachments
Patch (4.67 KB, patch)
2017-06-08 05:21 PDT, Carlos Garcia Campos 		zan: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-08 05:21:32 PDT
Created attachment 312294 [details] Patch
Build Bot
Comment 2 2017-06-08 05:22:42 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Zan Dobersek
Comment 3 2017-06-08 06:33:45 PDT
Comment on attachment 312294 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312294&action=review > Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp:133 > + WebKitFindController* m_findController { nullptr }; We don't have to initialize this to nullptr here since the constructor initializes it anyway.
Carlos Garcia Campos
Comment 4 2017-06-08 22:24:44 PDT
Committed r217961: <http://trac.webkit.org/changeset/217961>
Note You need to log in before you can comment on or make changes to this bug.