Bug 173095 - [GTK] Use API::Findclient instead of the C API in WebKitFindController
Summary: [GTK] Use API::Findclient instead of the C API in WebKitFindController
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2017-06-08 05:19 PDT by Carlos Garcia Campos
Modified: 2017-06-08 22:24 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.67 KB, patch)
2017-06-08 05:21 PDT, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2017-06-08 05:19:43 PDT 
ssia
Comment 1 Carlos Garcia Campos 2017-06-08 05:21:32 PDT 
Created attachment 312294 [details]
Patch
Comment 2 Build Bot 2017-06-08 05:22:42 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Zan Dobersek 2017-06-08 06:33:45 PDT 
Comment on attachment 312294 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=312294&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitFindController.cpp:133
> +    WebKitFindController* m_findController { nullptr };

We don't have to initialize this to nullptr here since the constructor initializes it anyway.
Comment 4 Carlos Garcia Campos 2017-06-08 22:24:44 PDT 
Committed r217961: <http://trac.webkit.org/changeset/217961>