Summary: | Add Charlie Turner as contributor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Charlie Turner <cturner> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | buildbot, clopez, commit-queue, glenn, lforschler | ||||
Priority: | P2 | ||||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Charlie Turner
2017-06-07 06:01:12 PDT
Created attachment 312179 [details]
Patch
Attachment 312179 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5]
Total errors found: 1 in 2 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 312179 [details]
Patch
Looks good to me. I didn't knew about this Tools/Scripts/validate-committer-lists --canonicalize tool .. nice
Let's see if CQ can handle this despite of the style warning.
Comment on attachment 312179 [details] Patch Clearing flags on attachment: 312179 Committed r217883: <http://trac.webkit.org/changeset/217883> All reviewed patches have been landed. Closing bug. |