Bug 173055

Summary: Add Charlie Turner as contributor
Product: WebKit Reporter: Charlie Turner <cturner>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, clopez, commit-queue, glenn, lforschler
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Charlie Turner
Reported 2017-06-07 06:01:12 PDT
Carlos López (Igalia) suggested I add myself to the contributors.json file in IM message to make some additions to the Wiki.
Attachments
Patch (1.89 KB, patch)
2017-06-07 06:10 PDT, Charlie Turner 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Charlie Turner
Comment 1 2017-06-07 06:10:43 PDT
Created attachment 312179 [details] Patch
Build Bot
Comment 2 2017-06-07 06:12:57 PDT
Attachment 312179 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0: contributors.json should not be modified through the commit queue [json/syntax] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Carlos Alberto Lopez Perez
Comment 3 2017-06-07 07:39:21 PDT
Comment on attachment 312179 [details] Patch Looks good to me. I didn't knew about this Tools/Scripts/validate-committer-lists --canonicalize tool .. nice Let's see if CQ can handle this despite of the style warning.
WebKit Commit Bot
Comment 4 2017-06-07 08:08:17 PDT
Comment on attachment 312179 [details] Patch Clearing flags on attachment: 312179 Committed r217883: <http://trac.webkit.org/changeset/217883>
WebKit Commit Bot
Comment 5 2017-06-07 08:08:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.