Summary: | [WK2][Cocoa] Allow network process to bind addresses without webrtc extension | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||||||||
Component: | WebKit2 | Assignee: | Brent Fulgham <bfulgham> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | achristensen, bfulgham, buildbot, commit-queue, darin, rniwa, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Brent Fulgham
2017-06-06 13:58:16 PDT
Created attachment 312120 [details]
Patch
Comment on attachment 312120 [details] Patch Attachment 312120 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3884066 New failing tests: webrtc/peer-connection-remote-audio-mute.html webrtc/video-remote-mute.html webrtc/multi-video.html webrtc/datachannel/basic.html webrtc/video.html webrtc/video-mediastreamtrack-stats.html webrtc/video-addTrack.html webrtc/video-stats.html webrtc/video-with-receiver.html webrtc/datachannel/datachannel-gc.html webrtc/datachannel/datachannel-stats.html webrtc/connection-state.html webrtc/no-port-zero-in-upd-candidates.html webrtc/peer-connection-audio-unmute.html webrtc/video-unmute.html webrtc/video-disabled-black.html webrtc/video-autoplay.html webrtc/video-with-data-channel.html Created attachment 312134 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6
Doh! I should have said ENABLE_WEB_RTC instead of ENABLE(WEB_RTC) in the sandbox template file. (In reply to Brent Fulgham from comment #5) > Doh! I should have said ENABLE_WEB_RTC instead of ENABLE(WEB_RTC) in the > sandbox template file. Actually, it doesn't look like we support conditionalizing based on feature flags. I'll just remove the guard, since we always build Cocoa with this on, and no other port uses our sandbox profile. Created attachment 312145 [details]
Patch
Created attachment 312146 [details]
Patch v3.
Comment on attachment 312146 [details]
Patch v3.
There was an extra set of parenthesis in the rule.
Comment on attachment 312146 [details] Patch v3. Clearing flags on attachment: 312146 Committed r217871: <http://trac.webkit.org/changeset/217871> All reviewed patches have been landed. Closing bug. |