Bug 173032

Summary:

[WK2][Cocoa] Allow network process to bind addresses without webrtc extension

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

WebKit2

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, bfulgham, buildbot, commit-queue, darin, rniwa, webkit-bug-importer, youennf

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews104 for mac-elcapitan-wk2	none
Patch	none
Patch v3.	none

Brent Fulgham

Reported 2017-06-06 13:58:16 PDT

We initially though we would restrict webrtc access to clients that included the "com.apple.webkit.webrtc" extension. However, we have since decided that all WebKit clients should be able to use the webrtc transport layer, so no special extensions are needed to support this. Simplify the implementation by removing these unnecessary checks.

Attachments
Patch (6.70 KB, patch) 2017-06-06 14:08 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews104 for mac-elcapitan-wk2 (1.85 MB, application/zip) 2017-06-06 16:13 PDT, Build Bot	no flags	Details
Patch (6.64 KB, patch) 2017-06-06 17:33 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Patch v3. (6.64 KB, patch) 2017-06-06 17:37 PDT, Brent Fulgham	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2017-06-06 14:03:37 PDT

<rdar://problem/32597426>

Brent Fulgham

Comment 2 2017-06-06 14:08:27 PDT

Created attachment 312120 [details] Patch

Build Bot

Comment 3 2017-06-06 16:13:25 PDT

Comment on attachment 312120 [details] Patch Attachment 312120 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3884066 New failing tests: webrtc/peer-connection-remote-audio-mute.html webrtc/video-remote-mute.html webrtc/multi-video.html webrtc/datachannel/basic.html webrtc/video.html webrtc/video-mediastreamtrack-stats.html webrtc/video-addTrack.html webrtc/video-stats.html webrtc/video-with-receiver.html webrtc/datachannel/datachannel-gc.html webrtc/datachannel/datachannel-stats.html webrtc/connection-state.html webrtc/no-port-zero-in-upd-candidates.html webrtc/peer-connection-audio-unmute.html webrtc/video-unmute.html webrtc/video-disabled-black.html webrtc/video-autoplay.html webrtc/video-with-data-channel.html

Build Bot

Comment 4 2017-06-06 16:13:26 PDT

Created attachment 312134 [details] Archive of layout-test-results from ews104 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Brent Fulgham

Comment 5 2017-06-06 17:21:16 PDT

Doh! I should have said ENABLE_WEB_RTC instead of ENABLE(WEB_RTC) in the sandbox template file.

Brent Fulgham

Comment 6 2017-06-06 17:28:44 PDT

(In reply to Brent Fulgham from comment #5) > Doh! I should have said ENABLE_WEB_RTC instead of ENABLE(WEB_RTC) in the > sandbox template file. Actually, it doesn't look like we support conditionalizing based on feature flags. I'll just remove the guard, since we always build Cocoa with this on, and no other port uses our sandbox profile.

Brent Fulgham

Comment 7 2017-06-06 17:33:51 PDT

Created attachment 312145 [details] Patch

Brent Fulgham

Comment 8 2017-06-06 17:37:54 PDT

Created attachment 312146 [details] Patch v3.

Brent Fulgham

Comment 9 2017-06-06 17:38:24 PDT

Comment on attachment 312146 [details] Patch v3. There was an extra set of parenthesis in the rule.

WebKit Commit Bot

Comment 10 2017-06-06 20:25:15 PDT

Comment on attachment 312146 [details] Patch v3. Clearing flags on attachment: 312146 Committed r217871: <http://trac.webkit.org/changeset/217871>

WebKit Commit Bot

Comment 11 2017-06-06 20:25:17 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.