Summary: | Update to slightly stricter rules for custom element names from more recent standard draft | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Darin Adler <darin> | ||||||||
Component: | DOM | Assignee: | Darin Adler <darin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | buildbot, cdumez, dbates, esprehn+autocc, kangil.han, rniwa, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 154907 | ||||||||||
Attachments: |
|
Description
Darin Adler
2017-06-06 11:27:51 PDT
Created attachment 312096 [details]
Patch
Test coverage is not great. Created attachment 312103 [details]
Patch
Created attachment 312109 [details]
Patch
All the tests passed so now it’s definitely ready for review. Comment on attachment 312109 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312109&action=review > Source/WebCore/dom/Document.cpp:1065 > +// https://www.w3.org/TR/custom-elements/#valid-custom-element-name Please use https://html.spec.whatwg.org/#valid-custom-element-name instead since that's spec is obsolete. Nice fix! Committed r217864: <http://trac.webkit.org/changeset/217864> |