Bug 17301

Summary: (Acid3) width/height media queries need to use the correct viewport and update on viewport-resize
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: CSSAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 17064    
Attachments:
Description Flags
Work in progress
none
Patch for review oliver: review+

Dave Hyatt
Reported 2008-02-10 17:32:56 PST
width/height media queries are always being evaluated with respect to the top-level frame. This is wrong.
Attachments
Work in progress (15.40 KB, patch)
2008-02-10 17:43 PST, Dave Hyatt 		no flags
DetailsFormatted DiffDiff
Patch for review (21.92 KB, patch)
2008-02-21 14:58 PST, Dave Hyatt 		oliver: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2008-02-10 17:33:44 PST
This is the reason test 46 of Acid3 now fails.
Dave Hyatt
Comment 2 2008-02-10 17:43:48 PST
Created attachment 19055 [details] Work in progress This patch gets us further in the media queries section. However, we fail once the viewport is dynamically resized. In order to pass we'll need to record the fact that we are "viewport-sensitive" and force a complete style recalc on every resize (ugh).
Dave Hyatt
Comment 3 2008-02-21 14:58:53 PST
Created attachment 19262 [details] Patch for review
Oliver Hunt
Comment 4 2008-02-21 16:01:32 PST
Comment on attachment 19262 [details] Patch for review r=me with a testcase -- text only if possible :D
Dave Hyatt
Comment 5 2008-02-21 16:16:34 PST
Fixed in r30466-7.
Note You need to log in before you can comment on or make changes to this bug.