Bug 173009

Summary: Exempt exclusively wall-powered devices from hardware codec requirement
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, commit-queue, darin, eric.carlson
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Jer Noble
Reported 2017-06-06 10:44:12 PDT
Exempt exclusively wall-powered devices from hardware codec requirement
Attachments
Patch (2.68 KB, patch)
2017-06-06 11:28 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.63 KB, patch)
2017-06-06 13:19 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (2.64 KB, patch)
2017-06-06 13:24 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (6.99 KB, patch)
2017-06-06 16:19 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (6.99 KB, patch)
2017-06-07 14:39 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2017-06-06 11:28:16 PDT
Created attachment 312094 [details] Patch
Darin Adler
Comment 2 2017-06-06 12:27:50 PDT
Comment on attachment 312094 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312094&action=review > Source/WebCore/platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:46 > + RetainPtr<CFArrayRef> powerSourcesList = IOPSCopyPowerSourcesList(powerSourcesInfo.get()); Leak here. Forgot to call adoptCF.
Jer Noble
Comment 3 2017-06-06 13:19:38 PDT
Created attachment 312112 [details] Patch
Jer Noble
Comment 4 2017-06-06 13:24:26 PDT
Created attachment 312113 [details] Patch
Jer Noble
Comment 5 2017-06-06 16:19:06 PDT
Created attachment 312137 [details] Patch
Alexey Proskuryakov
Comment 6 2017-06-06 17:15:16 PDT
Comment on attachment 312137 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312137&action=review > Source/WebCore/platform/spi/cocoa/IOPSLibSPI.h:44 > +CFTypeRef IOPSCopyPowerSourcesInfo(void); > +CFArrayRef IOPSCopyPowerSourcesList(CFTypeRef blob); > +CFDictionaryRef IOPSGetPowerSourceDescription(CFTypeRef blob, CFTypeRef ps); These shouldn't be in an #else block. We want the compiler to complain when there are changes to function signatures.
Jer Noble
Comment 7 2017-06-07 14:39:25 PDT
Created attachment 312232 [details] Patch
WebKit Commit Bot
Comment 8 2017-06-07 15:18:59 PDT
Comment on attachment 312232 [details] Patch Clearing flags on attachment: 312232 Committed r217906: <http://trac.webkit.org/changeset/217906>
WebKit Commit Bot
Comment 9 2017-06-07 15:19:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.