Bug 173000

Summary: Run webgl tests on iOS ports
Product: WebKit Reporter: Jonathan Bedard <jbedard>
Component: WebGLAssignee: Jonathan Bedard <jbedard>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, dino, dpaddock, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=174100
Attachments:
Description Flags
Patch for landing
none
Patch for landing none

Description Jonathan Bedard 2017-06-06 10:16:24 PDT 
Currently, we don't run webgl tests on iOS.  My recollection from testing these locally is that most do work on iOS simulator.  Even if we don't want to run the tests on simulator, we should absolutely be running them on device.
Comment 1 Radar WebKit Bug Importer 2017-06-06 10:17:13 PDT 
<rdar://problem/32591505>
Comment 2 Jonathan Bedard 2017-06-30 16:48:52 PDT 
Created attachment 314324 [details]
Patch for landing
Comment 3 WebKit Commit Bot 2017-06-30 17:37:26 PDT 
The commit-queue encountered the following flaky tests while processing attachment 314324 [details]:

The commit-queue is continuing to process your patch.
Comment 4 WebKit Commit Bot 2017-06-30 17:37:39 PDT 
The commit-queue encountered the following flaky tests while processing attachment 314324 [details]:

fast/workers/worker-exception-during-navigation.html bug 174058
The commit-queue is continuing to process your patch.
Comment 5 WebKit Commit Bot 2017-06-30 21:09:03 PDT 
The commit-queue encountered the following flaky tests while processing attachment 314324 [details]:

The commit-queue is continuing to process your patch.
Comment 6 WebKit Commit Bot 2017-06-30 21:09:04 PDT 
The commit-queue encountered the following flaky tests while processing attachment 314324 [details]:

The commit-queue is continuing to process your patch.
Comment 7 WebKit Commit Bot 2017-06-30 22:57:44 PDT 
Comment on attachment 314324 [details]
Patch for landing

Clearing flags on attachment: 314324

Committed r219044: <http://trac.webkit.org/changeset/219044>
Comment 8 WebKit Commit Bot 2017-06-30 22:57:45 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 9 Jonathan Bedard 2017-07-03 10:32:05 PDT 
Reopening to attach new patch.
Comment 10 Jonathan Bedard 2017-07-03 10:32:06 PDT 
Created attachment 314494 [details]
Patch for landing
Comment 11 WebKit Commit Bot 2017-07-03 11:32:14 PDT 
Comment on attachment 314494 [details]
Patch for landing

Rejecting attachment 314494 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 314494, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 219076 = b65f09c92f05a32cff07ec2e94b4cc5408982c78
r219078 = 408c56c0c4230bbb7de8fb5fdfbcfc4eec0c4f2c
r219079 = d29a64d99cdb76d0ab219ebd29e226b7b2d8f4a6
r219080 = 0acdd1ffd7d08e222b3f8189cba3a4d39061880c
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/4045956
Comment 12 Jonathan Bedard 2017-07-03 12:05:54 PDT 
Committed additional gardening in <http://trac.webkit.org/changeset/219085>.