Bug 172956

Summary:

[WebIDL] PutForwards is not implemented to spec as illustrated by the WPT WebIDL/ecmascript-binding/put-forwards.html

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, rniwa

Priority:

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Archive of layout-test-results from ews100 for mac-elcapitan	none
Archive of layout-test-results from ews105 for mac-elcapitan-wk2	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Archive of layout-test-results from ews117 for mac-elcapitan	none
Patch	cdumez: review+, cdumez: commit-queue-

Sam Weinig

Reported 2017-06-05 21:09:58 PDT

[WebIDL] PutForwards is not implemented to spec as illustrated by the WPT WebIDL/ecmascript-binding/put-forwards.html

Attachments
Patch (66.18 KB, patch) 2017-06-05 21:13 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (12.82 KB, patch) 2017-06-05 21:24 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Patch (11.37 KB, patch) 2017-06-05 21:28 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews100 for mac-elcapitan (972.66 KB, application/zip) 2017-06-05 22:34 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews105 for mac-elcapitan-wk2 (1.10 MB, application/zip) 2017-06-05 22:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews124 for ios-simulator-wk2 (1017.09 KB, application/zip) 2017-06-05 22:46 PDT, Build Bot	no flags	Details
Archive of layout-test-results from ews117 for mac-elcapitan (1.74 MB, application/zip) 2017-06-05 22:58 PDT, Build Bot	no flags	Details
Patch (13.03 KB, patch) 2017-06-06 15:09 PDT, Sam Weinig	cdumez: review+ cdumez: commit-queue-	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-06-05 21:13:56 PDT Comment hidden (obsolete)

Created attachment 312050 [details] Patch

Sam Weinig

Comment 2 2017-06-05 21:24:41 PDT Comment hidden (obsolete)

Created attachment 312051 [details] Patch

Sam Weinig

Comment 3 2017-06-05 21:28:44 PDT Comment hidden (obsolete)

Created attachment 312052 [details] Patch

Build Bot

Comment 4 2017-06-05 22:34:54 PDT Comment hidden (obsolete)

Comment on attachment 312052 [details] Patch Attachment 312052 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/3879564 New failing tests: http/tests/security/xss-DENIED-contentWindow-eval.html

Build Bot

Comment 5 2017-06-05 22:34:55 PDT Comment hidden (obsolete)

Created attachment 312054 [details] Archive of layout-test-results from ews100 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews100 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Build Bot

Comment 6 2017-06-05 22:37:39 PDT Comment hidden (obsolete)

Comment on attachment 312052 [details] Patch Attachment 312052 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/3879563 New failing tests: http/tests/security/xss-DENIED-contentWindow-eval.html

Build Bot

Comment 7 2017-06-05 22:37:40 PDT Comment hidden (obsolete)

Created attachment 312055 [details] Archive of layout-test-results from ews105 for mac-elcapitan-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews105 Port: mac-elcapitan-wk2 Platform: Mac OS X 10.11.6

Build Bot

Comment 8 2017-06-05 22:46:00 PDT Comment hidden (obsolete)

Comment on attachment 312052 [details] Patch Attachment 312052 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3879530 New failing tests: http/tests/security/xss-DENIED-contentWindow-eval.html

Build Bot

Comment 9 2017-06-05 22:46:01 PDT Comment hidden (obsolete)

Created attachment 312056 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Build Bot

Comment 10 2017-06-05 22:58:43 PDT Comment hidden (obsolete)

Comment on attachment 312052 [details] Patch Attachment 312052 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/3879582 New failing tests: http/tests/security/xss-DENIED-contentWindow-eval.html

Build Bot

Comment 11 2017-06-05 22:58:44 PDT Comment hidden (obsolete)

Created attachment 312057 [details] Archive of layout-test-results from ews117 for mac-elcapitan The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-elcapitan Platform: Mac OS X 10.11.6

Sam Weinig

Comment 12 2017-06-06 15:09:10 PDT

Created attachment 312128 [details] Patch

Chris Dumez

Comment 13 2017-06-07 09:03:04 PDT

Comment on attachment 312128 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312128&action=review r=me > Source/WebCore/ChangeLog:7 > + Link to the spec? > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4601 > + # FIXME: What should the second value to the PutPropertySlot be? We should probably file a bug against the WebIDL spec about the missing "Throw" argument to ES's Set(): Perform ? Set(Q, forwardId, V). I am assuming false is the right thing to do though. > LayoutTests/imported/w3c/ChangeLog:10 > +2017-06-05 Sam Weinig <sam@webkit.org> Double changelog.

Sam Weinig

Comment 14 2017-06-07 11:22:00 PDT

(In reply to Chris Dumez from comment #13) > Comment on attachment 312128 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312128&action=review > > r=me > > > Source/WebCore/ChangeLog:7 > > + > > Link to the spec? > > > Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4601 > > + # FIXME: What should the second value to the PutPropertySlot be? > > We should probably file a bug against the WebIDL spec about the missing https://github.com/heycam/webidl/issues/368 > "Throw" argument to ES's Set(): > Perform ? Set(Q, forwardId, V). > > I am assuming false is the right thing to do though. It might be based on strict mode or not. I'm not really sure. > > > LayoutTests/imported/w3c/ChangeLog:10 > > +2017-06-05 Sam Weinig <sam@webkit.org> > > Double changelog. :( I should make the style checker catch this, but I hate the style checker.

Sam Weinig

Comment 15 2017-06-07 11:57:28 PDT

Committed r217895: <http://trac.webkit.org/changeset/217895>

Note You need to log in before you can comment on or make changes to this bug.