Summary: | Safari doesn't load newest The Order of the Stick comic. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | agomez, bfulgham, commit-queue, koivisto, sam, simon.fraser, zalan | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
zalan
2017-06-05 19:49:44 PDT
Created attachment 312046 [details]
Patch
Created attachment 312047 [details]
Patch
Comment on attachment 312047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312047&action=review > Source/WebCore/ChangeLog:16 > + Need to add a testcase. Agreed :). Comment on attachment 312047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312047&action=review > Source/WebCore/ChangeLog:11 > + chain dirty, this dirty flag on the RenderTableRows will never be cleared and we'll end up early returning from RenderTableRow::paint. RenderTableRow::paint() doesn't early return on needsLayout does it? I don't see that in the code. (In reply to Simon Fraser (smfr) from comment #5) > Comment on attachment 312047 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312047&action=review > > > Source/WebCore/ChangeLog:11 > > + chain dirty, this dirty flag on the RenderTableRows will never be cleared and we'll end up early returning from RenderTableRow::paint. > > RenderTableRow::paint() doesn't early return on needsLayout does it? I don't > see that in the code. Right, my mistake. It's the RenderTableSection::paint. Weird that RenderTableSection has an early return that prevents painting. I guess we were just working around other table dirty layout bugs. We should remove that, or just paint a diagnostic color or something. (In reply to Simon Fraser (smfr) from comment #7) > Weird that RenderTableSection has an early return that prevents painting. I > guess we were just working around other table dirty layout bugs. We should > remove that, or just paint a diagnostic color or something. Agree. I don't mind removing it in a separate patch. Comment on attachment 312047 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312047&action=review > Source/WebCore/rendering/RenderBlockFlow.cpp:3698 > + if (needsLayout()) > + return; > + // FIXME: We should just kick off a subtree layout here (if needed at all) see webkit.org/b/172947. > + setNeedsLayout(); Maybe we can just remove this at some point. Created attachment 312098 [details]
Patch
Comment on attachment 312098 [details] Patch Clearing flags on attachment: 312098 Committed r217848: <http://trac.webkit.org/changeset/217848> All reviewed patches have been landed. Closing bug. Comment on attachment 312098 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312098&action=review > LayoutTests/fast/table/floating-table-sibling-is-invisible.html:13 > + font-size: 10px; There is a tab here. *** Bug 169742 has been marked as a duplicate of this bug. *** |