Bug 172942

Summary: Update JSC's features.json
Product: WebKit Reporter: Saam Barati <saam>
Component: JavaScriptCoreAssignee: Saam Barati <saam>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, ddkilzer, fpizlo, ggaren, gskachkov, jfbastien, jond, keith_miller, mark.lam, msaboff, simon.fraser, ticaiolima, ysuzuki
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=172958

Saam Barati
Reported 2017-06-05 16:25:56 PDT
...
Attachments
Saam Barati
Comment 1 2017-06-05 16:32:48 PDT
Saam Barati
Comment 2 2017-06-05 16:32:59 PDT
Rubber stamped by Mark Lam in person.
Saam Barati
Comment 3 2017-06-05 17:19:08 PDT
*** Bug 172865 has been marked as a duplicate of this bug. ***
David Kilzer (:ddkilzer)
Comment 4 2017-06-05 20:55:13 PDT
The <https://webkit.org/status/> page may have broken after this change. Tried to fix it with: <https://trac.webkit.org/r217816> However, that didn't seem to change anything.
David Kilzer (:ddkilzer)
Comment 5 2017-06-05 21:27:56 PDT
So I think the problem is that "ESNext" was used as a specification in a feature, but it wasn't listed in the "specification" section at the top of features.json. Should we change "ESNext" to "ES7", or add an entry for "ESNext"? { "name": "ES7", "url": "https://github.com/tc39/ecma262", "keywords": ["es7", "ecmascript"] }, { "name": "ESNext", "url": "https://tc39.github.io/ecma262/", "keywords": ["esnext", "ecmascript"] },
Saam Barati
Comment 6 2017-06-05 21:51:43 PDT
(In reply to David Kilzer (:ddkilzer) from comment #5) > So I think the problem is that "ESNext" was used as a specification in a > feature, but it wasn't listed in the "specification" section at the top of > features.json. > > Should we change "ESNext" to "ES7", or add an entry for "ESNext"? > > { > "name": "ES7", > "url": "https://github.com/tc39/ecma262", > "keywords": ["es7", "ecmascript"] > }, > { > "name": "ESNext", > "url": "https://tc39.github.io/ecma262/", > "keywords": ["esnext", "ecmascript"] > }, I'll update with a new ESNext section.
Saam Barati
Comment 7 2017-06-05 21:51:53 PDT
(In reply to Saam Barati from comment #6) > (In reply to David Kilzer (:ddkilzer) from comment #5) > > So I think the problem is that "ESNext" was used as a specification in a > > feature, but it wasn't listed in the "specification" section at the top of > > features.json. > > > > Should we change "ESNext" to "ES7", or add an entry for "ESNext"? > > > > { > > "name": "ES7", > > "url": "https://github.com/tc39/ecma262", > > "keywords": ["es7", "ecmascript"] > > }, > > { > > "name": "ESNext", > > "url": "https://tc39.github.io/ecma262/", > > "keywords": ["esnext", "ecmascript"] > > }, > > I'll update with a new ESNext section. About to land now.
Saam Barati
Comment 8 2017-06-05 21:54:07 PDT
landed follow up ESNext section in: https://trac.webkit.org/changeset/217819/webkit Thanks for looking into this Dave.
Saam Barati
Comment 9 2017-06-05 21:54:49 PDT
Simon Fraser (smfr)
Comment 10 2017-06-05 22:01:40 PDT
I filed bug 172958 to do more json validation.
Note You need to log in before you can comment on or make changes to this bug.