Bug 172942
Summary: | Update JSC's features.json | ||
---|---|---|---|
Product: | WebKit | Reporter: | Saam Barati <saam> |
Component: | JavaScriptCore | Assignee: | Saam Barati <saam> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | benjamin, ddkilzer, fpizlo, ggaren, gskachkov, jfbastien, jond, keith_miller, mark.lam, msaboff, simon.fraser, ticaiolima, ysuzuki |
Priority: | P2 | ||
Version: | WebKit Nightly Build | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=172958 |
Saam Barati
...
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Saam Barati
landed in:
https://trac.webkit.org/changeset/217805/webkit
Saam Barati
Rubber stamped by Mark Lam in person.
Saam Barati
*** Bug 172865 has been marked as a duplicate of this bug. ***
David Kilzer (:ddkilzer)
The <https://webkit.org/status/> page may have broken after this change. Tried to fix it with:
<https://trac.webkit.org/r217816>
However, that didn't seem to change anything.
David Kilzer (:ddkilzer)
So I think the problem is that "ESNext" was used as a specification in a feature, but it wasn't listed in the "specification" section at the top of features.json.
Should we change "ESNext" to "ES7", or add an entry for "ESNext"?
{
"name": "ES7",
"url": "https://github.com/tc39/ecma262",
"keywords": ["es7", "ecmascript"]
},
{
"name": "ESNext",
"url": "https://tc39.github.io/ecma262/",
"keywords": ["esnext", "ecmascript"]
},
Saam Barati
(In reply to David Kilzer (:ddkilzer) from comment #5)
> So I think the problem is that "ESNext" was used as a specification in a
> feature, but it wasn't listed in the "specification" section at the top of
> features.json.
>
> Should we change "ESNext" to "ES7", or add an entry for "ESNext"?
>
> {
> "name": "ES7",
> "url": "https://github.com/tc39/ecma262",
> "keywords": ["es7", "ecmascript"]
> },
> {
> "name": "ESNext",
> "url": "https://tc39.github.io/ecma262/",
> "keywords": ["esnext", "ecmascript"]
> },
I'll update with a new ESNext section.
Saam Barati
(In reply to Saam Barati from comment #6)
> (In reply to David Kilzer (:ddkilzer) from comment #5)
> > So I think the problem is that "ESNext" was used as a specification in a
> > feature, but it wasn't listed in the "specification" section at the top of
> > features.json.
> >
> > Should we change "ESNext" to "ES7", or add an entry for "ESNext"?
> >
> > {
> > "name": "ES7",
> > "url": "https://github.com/tc39/ecma262",
> > "keywords": ["es7", "ecmascript"]
> > },
> > {
> > "name": "ESNext",
> > "url": "https://tc39.github.io/ecma262/",
> > "keywords": ["esnext", "ecmascript"]
> > },
>
> I'll update with a new ESNext section.
About to land now.
Saam Barati
landed follow up ESNext section in:
https://trac.webkit.org/changeset/217819/webkit
Thanks for looking into this Dave.
Saam Barati
https://webkit.org/status/ appears to work.
Simon Fraser (smfr)
I filed bug 172958 to do more json validation.