Bug 172923

Summary: [GStreamer] Use the same draw timer and mutex when AC disabled or building without OpenGL
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, magomez, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-06-05 09:32:30 PDT
We have two different paths to do the same, when building without OpenGL, the VideoRenderRequestScheduler has its own timer and we need to add ifdefs to handle that. But when building with OpenGL we still support non-accelerated rendering that does the same than the VideoRenderRequestScheduler timer, but using the media player timer instead. We can simplify the code and remove more ifdefs by using the media player timer and mutex in all cases for non-accelerated rendering.
Attachments
Patch (7.94 KB, patch)
2017-06-05 09:35 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-05 09:35:22 PDT
Created attachment 312012 [details] Patch
Michael Catanzaro
Comment 2 2017-06-05 14:23:04 PDT
Comment on attachment 312012 [details] Patch Nice! r=me, conditional on Miguel's approval.
Miguel Gomez
Comment 3 2017-06-06 01:32:06 PDT
Looks good and usual use cases work :)
Carlos Garcia Campos
Comment 4 2017-06-06 01:38:44 PDT
I built without OpenGL yesterday to try it out.
Carlos Garcia Campos
Comment 5 2017-06-06 02:01:24 PDT
Committed r217824: <http://trac.webkit.org/changeset/217824>
Note You need to log in before you can comment on or make changes to this bug.