Bug 172921

Summary: [WPE][JHBuild] Switch github repository from git:// to https://
Product: WebKit Reporter: Carlos Alberto Lopez Perez <clopez>
Component: Tools / TestsAssignee: Carlos Alberto Lopez Perez <clopez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, lforschler, mark.salisbury, mcatanzaro, zan
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=148941
Attachments:
Description Flags
Patch none

Carlos Alberto Lopez Perez
Reported 2017-06-05 09:08:31 PDT
On bug 148941 some developers reported having trouble to fetch resources of the WebKitGTK+ JHBuild not served via http or https due to restrictive firewalls they had to suffer. So, let's try to do this also for the WPE port.
Attachments
Patch (1.64 KB, patch)
2017-06-05 09:13 PDT, Carlos Alberto Lopez Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Michael Catanzaro
Comment 1 2017-06-05 09:12:16 PDT
This is good to do anyway, independent of problematic firewalls.
Carlos Alberto Lopez Perez
Comment 2 2017-06-05 09:13:40 PDT
Created attachment 312011 [details] Patch
Alex Christensen
Comment 3 2017-06-05 13:08:59 PDT
Comment on attachment 312011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=312011&action=review > Tools/wpe/jhbuild.modules:30 > + <!-- Please use http/https to access repositories to be friendly to users stuck behind firewalls. --> Should we only allow https?
Carlos Alberto Lopez Perez
Comment 4 2017-06-05 13:19:35 PDT
(In reply to Alex Christensen from comment #3) > Comment on attachment 312011 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=312011&action=review > > > Tools/wpe/jhbuild.modules:30 > > + <!-- Please use http/https to access repositories to be friendly to users stuck behind firewalls. --> > > Should we only allow https? Thanks! I think is a good idea defaulting to https, but some sites may still only be accessible via http. In any case JHBuild always checks the hash or the source tarball after downloading it.
WebKit Commit Bot
Comment 5 2017-06-05 13:54:11 PDT
Comment on attachment 312011 [details] Patch Clearing flags on attachment: 312011 Committed r217792: <http://trac.webkit.org/changeset/217792>
WebKit Commit Bot
Comment 6 2017-06-05 13:54:13 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 7 2017-06-05 14:24:17 PDT
(In reply to Carlos Alberto Lopez Perez from comment #4) > In any case JHBuild always checks the hash or the source tarball after > downloading it. Well it's certainly supposed to... though if I remember correctly, when I tested this once before it didn't work.
Carlos Alberto Lopez Perez
Comment 8 2017-06-05 16:28:45 PDT
(In reply to Michael Catanzaro from comment #7) > (In reply to Carlos Alberto Lopez Perez from comment #4) > > In any case JHBuild always checks the hash or the source tarball after > > downloading it. > > Well it's certainly supposed to... though if I remember correctly, when I > tested this once before it didn't work. Really? I tested this several times and it always worked as expected for me.
Michael Catanzaro
Comment 9 2017-06-05 19:04:05 PDT
Well, that's good then.
Note You need to log in before you can comment on or make changes to this bug.