Bug 172918

Summary: [GStreamer] Cleanup ifdefs in MediaPlayerPrivateGStreamerBase
Product: WebKit Reporter: Carlos Garcia Campos <cgarcia>
Component: PlatformAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: magomez, mcatanzaro
Priority: P2 Keywords: Gtk
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 170003    
Attachments:
Description Flags
Patch mcatanzaro: review+

Carlos Garcia Campos
Reported 2017-06-05 06:04:20 PDT
The code in MediaPlayerPrivateGStreamerBase is quite difficult to follow with all the ifdefs for the possibilities when rendering. Some of them are even dead code now that all ports using GStreamer are using also coordinated graphics.
Attachments
Patch (17.08 KB, patch)
2017-06-05 06:30 PDT, Carlos Garcia Campos 		mcatanzaro: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Carlos Garcia Campos
Comment 1 2017-06-05 06:30:38 PDT
Created attachment 312008 [details] Patch
Miguel Gomez
Comment 2 2017-06-05 08:29:29 PDT
(In reply to Carlos Garcia Campos from comment #1) > Created attachment 312008 [details] > Patch Looks good to me, and video use cases seem to be working properly. At last getting rid of that code!! \o/
Michael Catanzaro
Comment 3 2017-06-05 09:20:55 PDT
Comment on attachment 312008 [details] Patch It's still a mess, but I see it's better than before. rs=me based on Miguel's review.
Michael Catanzaro
Comment 4 2017-06-05 09:21:40 PDT
Also, Calvaris, if you want to review these GStreamer patches, let me know and I'll leave r+ for you... I'm just assuming you're busy.
Carlos Garcia Campos
Comment 5 2017-06-05 09:26:06 PDT
Committed r217785: <http://trac.webkit.org/changeset/217785>
Note You need to log in before you can comment on or make changes to this bug.