Bug 172886

Summary: Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheCoreText.cpp
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dino, jonlee, simon.fraser, thorton
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 172893    
Attachments:
Description Flags
Patch
none
Patch none

Myles C. Maxfield
Reported 2017-06-02 18:11:29 PDT
Cleanup arguments to preparePlatformFont() and fontWithFamily() in FontCacheCoreText.cpp
Attachments
Patch (10.60 KB, patch)
2017-06-02 18:14 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (10.76 KB, patch)
2017-06-02 22:38 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-06-02 18:14:27 PDT
Created attachment 311896 [details] Patch
Myles C. Maxfield
Comment 2 2017-06-02 22:38:49 PDT
Created attachment 311906 [details] Patch
Simon Fraser (smfr)
Comment 3 2017-06-03 10:12:20 PDT
Comment on attachment 311906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311906&action=review > Source/WebCore/platform/graphics/FontCache.h:284 > +RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings* fontFaceFeatures, const FontVariantSettings* fontFaceVariantSettings, FontSelectionSpecifiedCapabilities fontFaceCapabilities, float size); Here this could be: RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings*, const FontVariantSettings*, FontSelectionSpecifiedCapabilities, float size);
Myles C. Maxfield
Comment 4 2017-06-03 10:37:36 PDT
Comment on attachment 311906 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311906&action=review >> Source/WebCore/platform/graphics/FontCache.h:284 >> +RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings* fontFaceFeatures, const FontVariantSettings* fontFaceVariantSettings, FontSelectionSpecifiedCapabilities fontFaceCapabilities, float size); > > Here this could be: > > RetainPtr<CTFontRef> preparePlatformFont(CTFontRef, const FontDescription&, const FontFeatureSettings*, const FontVariantSettings*, FontSelectionSpecifiedCapabilities, float size); I think, in this case, the argument names are helpful because the FontDescription also has members with these same types. The name describes how these values should be supplied from @font-face, rather than from the element's style itself.
WebKit Commit Bot
Comment 5 2017-06-03 11:07:20 PDT
Comment on attachment 311906 [details] Patch Clearing flags on attachment: 311906 Committed r217762: <http://trac.webkit.org/changeset/217762>
WebKit Commit Bot
Comment 6 2017-06-03 11:07:22 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.