Bug 172838 – Allow clients to override viewport size for CSS viewport units.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan baradlay]

vh, vw etc

[Radar WebKit Bug Importer]

<rdar://problem/32523441>

[alan baradlay]

Created attachment 311774 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 311774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311774&action=review

> Source/WebKit2/ChangeLog:11
> +        This enables auto-sizing clients to ensure that styles relative to the viewport are
> +        resolved to a set value (presumably the size of the container) as opposed to the preferred
> +        document size (which is set as the FrameView size).

How does this relate to fixedLayoutSize? Could we use that as something to resolve viewport units against?

[Tim Horton]

Comment on attachment 311774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311774&action=review

> Source/WebKit2/WebProcess/WebPage/WebPage.h:883
> +    std::optional<WebCore::IntSize> viewportSizeForCSSViewportUnits() { return m_viewportSizeForCSSViewportUnits; }

const?

[alan baradlay]

Created attachment 311798 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 311798 [details]
Patch

Clearing flags on attachment: 311798

Committed r217725: <http://trac.webkit.org/changeset/217725>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.