Bug 172833 – [JSCOnly] Build static jsc.exe on Windows

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Stephan Szabo]

Get a static build of jsc.exe on Windows with JSCOnly.

[Stephan Szabo]

Created attachment 311751 [details]
Patch to support static jsc.exe jsconly build on windows.

[Stephan Szabo]

Created attachment 311770 [details]
Updated patch for static jsc.exe jsconly build on Windows with less cruft

[Yusuke Suzuki]

Comment on attachment 311770 [details]
Updated patch for static jsc.exe jsconly build on Windows with less cruft

View in context: https://bugs.webkit.org/attachment.cgi?id=311770&action=review

r=me with comments.

> Source/WTF/wtf/PlatformJSCOnly.cmake:60
> +    list(APPEND WTF_LIBRARIES
> +        winmm
> +    )

Could you move these lines inside `if (WIN32)` in L20-24?

> Source/cmake/OptionsJSCOnly.cmake:48
> +# FIXME: JSCOnly on WIN32 seems to only work with fully static build

Could you open a bug for this FIXME and add URL here?

> Tools/CMakeLists.txt:31
> +elseif ("${PORT}" STREQUAL "Win")

Nice.

[Yusuke Suzuki]

BTW, it would be good decoupling Windows-related configurations from Windows ports options.
But, for now, only JSCOnly port will use this mechanism. And only small part of the Windows configurations is required to make JSCOnly work.
So, personally, this patch is ok for now.

[Stephan Szabo]

Created attachment 311840 [details]
Updated patch based on review comments

[Don Olmstead]

(In reply to Yusuke Suzuki from comment #4)
> BTW, it would be good decoupling Windows-related configurations from Windows
> ports options.
> But, for now, only JSCOnly port will use this mechanism. And only small part
> of the Windows configurations is required to make JSCOnly work.
> So, personally, this patch is ok for now.

One issue with that is the use of CF. AppleWin and WinCairo are using it. We plan to remove CF from WinCairo going forward though.

[Konstantin Tokarev]

Comment on attachment 311840 [details]
Updated patch based on review comments

View in context: https://bugs.webkit.org/attachment.cgi?id=311840&action=review

> Source/WTF/wtf/PlatformJSCOnly.cmake:24
> +    list(APPEND WTF_LIBRARIES

Please move this to Source/WTF/wtf/CMakeLists.txt

[Stephan Szabo]

Created attachment 311858 [details]
Updated patch moving win32 library add

[WebKit Commit Bot]

Comment on attachment 311858 [details]
Updated patch moving win32 library add

Rejecting attachment 311858 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 311858, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3861942

[WebKit Commit Bot]

Comment on attachment 311858 [details]
Updated patch moving win32 library add

Clearing flags on attachment: 311858

Committed r217736: <http://trac.webkit.org/changeset/217736>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.