Bug 172791

Summary:

Don't shouldn't create a request to build a patch if there is no patch to build

Product:

WebKit

Reporter:

Ryosuke Niwa <rniwa>

Component:

Perf Dashboard

Assignee:

Ryosuke Niwa <rniwa>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, rniwa

Priority:

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes the bug	none

Ryosuke Niwa

Reported 2017-05-31 18:28:38 PDT

When a perf try bots is scheduled with a commit set with a patch, and one without any patches, if the latter commit set's repository group doesn't match with that of the commit set with a patch, then we shouldn't create a request to build a patch for the commit set without a patch.

Attachments
Fixes the bug (9.20 KB, patch) 2017-05-31 18:51 PDT, Ryosuke Niwa	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ryosuke Niwa

Comment 1 2017-05-31 18:51:02 PDT

Created attachment 311671 [details] Fixes the bug

Ryosuke Niwa

Comment 2 2017-05-31 18:54:57 PDT

Thanks for the review.

Ryosuke Niwa

Comment 3 2017-05-31 18:55:53 PDT

Comment on attachment 311671 [details] Fixes the bug Clearing flags on attachment: 311671 Committed r217643: <http://trac.webkit.org/changeset/217643>

Ryosuke Niwa

Comment 4 2017-05-31 18:55:55 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.