Bug 172791 - Don't shouldn't create a request to build a patch if there is no patch to build
Summary: Don't shouldn't create a request to build a patch if there is no patch to build
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Perf Dashboard (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-05-31 18:28 PDT by Ryosuke Niwa
Modified: 2017-05-31 18:55 PDT (History)
2 users (show)

See Also:

Attachments
Fixes the bug (9.20 KB, patch)
2017-05-31 18:51 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2017-05-31 18:28:38 PDT 
When a perf try bots is scheduled with a commit set with a patch, and one without any patches, if the latter commit set's repository group doesn't match with that of the commit set with a patch, then we shouldn't create a request to build a patch for the commit set without a patch.
Comment 1 Ryosuke Niwa 2017-05-31 18:51:02 PDT 
Created attachment 311671 [details]
Fixes the bug
Comment 2 Ryosuke Niwa 2017-05-31 18:54:57 PDT 
Thanks for the review.
Comment 3 Ryosuke Niwa 2017-05-31 18:55:53 PDT 
Comment on attachment 311671 [details]
Fixes the bug

Clearing flags on attachment: 311671

Committed r217643: <http://trac.webkit.org/changeset/217643>
Comment 4 Ryosuke Niwa 2017-05-31 18:55:55 PDT 
All reviewed patches have been landed.  Closing bug.