Bug 172789

Summary: Remove overrides of visitChildren() that do not add any functionality.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, fpizlo, jfbastien, keith_miller, kling, msaboff, ryanhaddad, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch.
kling: review+, buildbot: commit-queue-
Archive of layout-test-results from ews123 for ios-simulator-wk2 none

Mark Lam
Reported 2017-05-31 17:21:11 PDT
Patch coming.
Attachments
proposed patch. (16.83 KB, patch)
2017-05-31 17:27 PDT, Mark Lam 		kling: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ews123 for ios-simulator-wk2 (906.55 KB, application/zip)
2017-05-31 18:54 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-05-31 17:23:37 PDT
<rdar://problem/32500865>
Mark Lam
Comment 2 2017-05-31 17:27:22 PDT
Created attachment 311663 [details] proposed patch.
Andreas Kling
Comment 3 2017-05-31 17:59:41 PDT
Comment on attachment 311663 [details] proposed patch. r=me
Mark Lam
Comment 4 2017-05-31 18:53:05 PDT
Thanks for the review.
Build Bot
Comment 5 2017-05-31 18:54:33 PDT
Comment on attachment 311663 [details] proposed patch. Attachment 311663 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3851362 New failing tests: webrtc/peer-connection-audio-mute.html
Build Bot
Comment 6 2017-05-31 18:54:35 PDT
Created attachment 311672 [details] Archive of layout-test-results from ews123 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews123 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Mark Lam
Comment 7 2017-05-31 20:06:28 PDT
(In reply to Build Bot from comment #5) > New failing tests: > webrtc/peer-connection-audio-mute.html This test has been failing intermittently on the ios-sim EWS for a long time now. It's not due to my patch.
Mark Lam
Comment 8 2017-05-31 20:11:40 PDT
Landed in r217645: <http://trac.webkit.org/r217645>.
Note You need to log in before you can comment on or make changes to this bug.