Bug 172782

Summary: CodeGeneratorJS's InstanceNeedsVisitChildren should not return true just because a class is / extends EventTarget.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, ryanhaddad, saam, sam, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch. none

Mark Lam
Reported 2017-05-31 15:49:53 PDT
The other conditions for generating visitChildren() are adequate if the class needs its own visitChildren. Currently, we're generating some visitChildren() methods that only call its Base::visitChildren(). Removing the "is / extends EventTarget" conditions removes those unneeded visitChildren() overrides.
Attachments
proposed patch. (10.02 KB, patch)
2017-05-31 16:17 PDT, Mark Lam 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-05-31 15:56:04 PDT
<rdar://problem/32498266>
Mark Lam
Comment 2 2017-05-31 16:07:37 PDT
Ditto for the IsJSBuiltinConstructor condition, which is not used to emit any additional code in the visitChildren override.
Mark Lam
Comment 3 2017-05-31 16:17:22 PDT
Created attachment 311651 [details] proposed patch. Let's test this on the EWS first.
Chris Dumez
Comment 4 2017-05-31 16:41:18 PDT
Comment on attachment 311651 [details] proposed patch. r=me as long as bots are happy.
Mark Lam
Comment 5 2017-05-31 16:43:03 PDT
Thanks for the review.
WebKit Commit Bot
Comment 6 2017-05-31 17:12:55 PDT
Comment on attachment 311651 [details] proposed patch. Clearing flags on attachment: 311651 Committed r217642: <http://trac.webkit.org/changeset/217642>
WebKit Commit Bot
Comment 7 2017-05-31 17:12:56 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.