Bug 172722

Summary: REGRESSION(r217515): Correct iterator invalidation bug (AGAIN)
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, cdumez, commit-queue, dbates, japhet, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2017-05-30 09:07:38 PDT
I reintroduced a bug involving an invalidated iterator in r217515. This returns this code to the "copy" behavior used prior to r217515.
Attachments
Patch (2.34 KB, patch)
2017-05-30 09:13 PDT, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-05-30 09:09:13 PDT
<rdar://problem/32462876>
Brent Fulgham
Comment 2 2017-05-30 09:13:45 PDT
Created attachment 311509 [details] Patch
WebKit Commit Bot
Comment 3 2017-05-30 09:57:24 PDT
Comment on attachment 311509 [details] Patch Clearing flags on attachment: 311509 Committed r217558: <http://trac.webkit.org/changeset/217558>
WebKit Commit Bot
Comment 4 2017-05-30 09:57:25 PDT
All reviewed patches have been landed. Closing bug.
Chris Dumez
Comment 5 2017-05-30 10:15:46 PDT
Comment on attachment 311509 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311509&action=review > Source/WebCore/loader/ResourceLoadObserver.cpp:158 > + // We must make a copy here, because later calls to 'ensureResourceStatisticsForPrimaryDomain' will invalidate the returned reference:: Extra ':'.
Brent Fulgham
Comment 6 2017-05-30 10:48:14 PDT
Rats! Typo fixed in: Committed r217561: <http://trac.webkit.org/changeset/217561>
Note You need to log in before you can comment on or make changes to this bug.