Bug 172722 - REGRESSION(r217515): Correct iterator invalidation bug (AGAIN)
Summary: REGRESSION(r217515): Correct iterator invalidation bug (AGAIN)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-30 09:07 PDT by Brent Fulgham
Modified: 2017-05-30 10:48 PDT (History)
8 users (show)

See Also:


Attachments
Patch (2.34 KB, patch)
2017-05-30 09:13 PDT, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2017-05-30 09:07:38 PDT
I reintroduced a bug involving an invalidated iterator in r217515. This returns this code to the "copy" behavior used prior to r217515.
Comment 1 Radar WebKit Bug Importer 2017-05-30 09:09:13 PDT
<rdar://problem/32462876>
Comment 2 Brent Fulgham 2017-05-30 09:13:45 PDT
Created attachment 311509 [details]
Patch
Comment 3 WebKit Commit Bot 2017-05-30 09:57:24 PDT
Comment on attachment 311509 [details]
Patch

Clearing flags on attachment: 311509

Committed r217558: <http://trac.webkit.org/changeset/217558>
Comment 4 WebKit Commit Bot 2017-05-30 09:57:25 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2017-05-30 10:15:46 PDT
Comment on attachment 311509 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311509&action=review

> Source/WebCore/loader/ResourceLoadObserver.cpp:158
> +        // We must make a copy here, because later calls to 'ensureResourceStatisticsForPrimaryDomain' will invalidate the returned reference::

Extra ':'.
Comment 6 Brent Fulgham 2017-05-30 10:48:14 PDT
Rats!

Typo fixed in:

Committed r217561: <http://trac.webkit.org/changeset/217561>