Bug 172721 – Use RareData's RenderStyle for display: contents.

• Component: CSS
• Status: RESOLVED FIXED

[Emilio Cobos Álvarez]

It will make some following fixes easier.

[Emilio Cobos Álvarez]

Created attachment 311510 [details]
Patch

[Build Bot]

Comment on attachment 311510 [details]
Patch

Attachment 311510 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/3842742

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html

[Build Bot]

Created attachment 311514 [details]
Archive of layout-test-results from ews100 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews100  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 311510 [details]
Patch

Attachment 311510 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/3842745

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html

[Build Bot]

Created attachment 311515 [details]
Archive of layout-test-results from ews104 for mac-elcapitan-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews104  Port: mac-elcapitan-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 311510 [details]
Patch

Attachment 311510 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/3842760

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html

[Build Bot]

Created attachment 311517 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.12.5

[Build Bot]

Comment on attachment 311510 [details]
Patch

Attachment 311510 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/3842776

New failing tests:
editing/execCommand/justify-right-then-indent-with-problematic-body.html

[Build Bot]

Created attachment 311519 [details]
Archive of layout-test-results from ews114 for mac-elcapitan

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews114  Port: mac-elcapitan  Platform: Mac OS X 10.11.6

[Emilio Cobos Álvarez]

Created attachment 311528 [details]
Patch

[Emilio Cobos Álvarez]

Hi Antti, could you review this?

This would facilitate the text style stuff, though per our IRC conversation I plan to hold off a bit on doing that. Do you think it's still worth to land something like this?

[Antti Koivisto]

Comment on attachment 311528 [details]
Patch

Looks good, r=me. Now that we have the cached style we can also fix some inefficiencies. For example hasDisplayContents test in shouldResolveElement() won't be needed. This can be done in a separate patch.

[Build Bot]

Comment on attachment 311528 [details]
Patch

Rejecting attachment 311528 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 311528 [details]
Patch

Clearing flags on attachment: 311528

Committed r217599: <http://trac.webkit.org/changeset/217599>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.