[Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Per Arne Vollan]

We should make sure we exit from fullscreen mode after a fullscreen test.

[Per Arne Vollan]

Created attachment 311500 [details]
Patch

[Brent Fulgham]

Comment on attachment 311500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311500&action=review

R=me but please make a new IWebViewPrivate5 interface to avoid breaking existing COM interface users.

> Source/WebKit/win/Interfaces/IWebViewPrivate.idl:350
> +    HRESULT exitFullscreenIfNeeded();

Sadly, we need to make an IWebViewPrivate5 here, because IWebViewPrivate4 already shipped to users, and we will break them if we modify the COM interface.

[Per Arne Vollan]

(In reply to Brent Fulgham from comment #2)
> Comment on attachment 311500 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311500&action=review
> 
> R=me but please make a new IWebViewPrivate5 interface to avoid breaking
> existing COM interface users.
> 
> > Source/WebKit/win/Interfaces/IWebViewPrivate.idl:350
> > +    HRESULT exitFullscreenIfNeeded();
> 
> Sadly, we need to make an IWebViewPrivate5 here, because IWebViewPrivate4
> already shipped to users, and we will break them if we modify the COM
> interface.

Thanks for reviewing! I will make an IWebViewPrivate5 interface before landing.

[Per Arne Vollan]

Committed <https://trac.webkit.org/changeset/217557/webkit>

[Radar WebKit Bug Importer]

<rdar://problem/32479628>