Bug 172709 - [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
Summary: [Win] fast/shadow-dom/fullscreen-in-slot-fullscreenElement.html is flaky.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-30 05:55 PDT by Per Arne Vollan
Modified: 2017-05-30 20:17 PDT (History)
4 users (show)

See Also:


Attachments
Patch (4.83 KB, patch)
2017-05-30 05:59 PDT, Per Arne Vollan
bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2017-05-30 05:55:11 PDT
We should make sure we exit from fullscreen mode after a fullscreen test.
Comment 1 Per Arne Vollan 2017-05-30 05:59:52 PDT
Created attachment 311500 [details]
Patch
Comment 2 Brent Fulgham 2017-05-30 07:00:30 PDT
Comment on attachment 311500 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311500&action=review

R=me but please make a new IWebViewPrivate5 interface to avoid breaking existing COM interface users.

> Source/WebKit/win/Interfaces/IWebViewPrivate.idl:350
> +    HRESULT exitFullscreenIfNeeded();

Sadly, we need to make an IWebViewPrivate5 here, because IWebViewPrivate4 already shipped to users, and we will break them if we modify the COM interface.
Comment 3 Per Arne Vollan 2017-05-30 08:03:21 PDT
(In reply to Brent Fulgham from comment #2)
> Comment on attachment 311500 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311500&action=review
> 
> R=me but please make a new IWebViewPrivate5 interface to avoid breaking
> existing COM interface users.
> 
> > Source/WebKit/win/Interfaces/IWebViewPrivate.idl:350
> > +    HRESULT exitFullscreenIfNeeded();
> 
> Sadly, we need to make an IWebViewPrivate5 here, because IWebViewPrivate4
> already shipped to users, and we will break them if we modify the COM
> interface.

Thanks for reviewing! I will make an IWebViewPrivate5 interface before landing.
Comment 4 Per Arne Vollan 2017-05-30 08:42:39 PDT
Committed <https://trac.webkit.org/changeset/217557/webkit>
Comment 5 Radar WebKit Bug Importer 2017-05-30 20:17:56 PDT
<rdar://problem/32479628>