Bug 172686

Summary: [JSC][Linux][FreeBSD] Use faster Interpreter::getOpcodeID()
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: New BugsAssignee: Yusuke Suzuki <ysuzuki>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, buildbot, cdumez, cgarcia, clopez, cmarcelo, dbates, mark.lam, mcatanzaro, webkit-bug-importer, zan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 172669    
Bug Blocks:    
Attachments:
Description Flags
Patch mark.lam: review+

Yusuke Suzuki
Reported 2017-05-28 04:40:06 PDT
[JSC][Linux][FreeBSD] Use faster Interpreter::getOpcodeID()
Attachments
Patch (1.76 KB, patch)
2017-05-28 04:44 PDT, Yusuke Suzuki 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2017-05-28 04:44:10 PDT
Created attachment 311435 [details] Patch
Mark Lam
Comment 2 2017-05-28 05:59:56 PDT
Comment on attachment 311435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311435&action=review r=me > Source/WTF/wtf/Platform.h:920 > + (CPU(X86) || CPU(X86_64) || CPU(ARM64) || CPU(ARM_THUMB2)) && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD)) Should this be enabled for all Unix OSes? If so, we can just drop the OS(DARWIN) instead. We already filter out MSVC above. What do you think?
Yusuke Suzuki
Comment 3 2017-05-28 06:13:09 PDT
Comment on attachment 311435 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311435&action=review >> Source/WTF/wtf/Platform.h:920 >> + (CPU(X86) || CPU(X86_64) || CPU(ARM64) || CPU(ARM_THUMB2)) && (OS(DARWIN) || OS(LINUX) || OS(FREEBSD)) > > Should this be enabled for all Unix OSes? If so, we can just drop the OS(DARWIN) instead. We already filter out MSVC above. What do you think? I think it is reasonable. Let's do that ;)
Yusuke Suzuki
Comment 4 2017-05-28 07:12:03 PDT
Committed r217528: <http://trac.webkit.org/changeset/217528>
Yusuke Suzuki
Comment 5 2017-05-28 10:37:29 PDT
Linux ARM Thumb2 crashes. I'll check it tomorrow.
Yusuke Suzuki
Comment 6 2017-05-29 03:38:03 PDT
Committed r217535: <http://trac.webkit.org/changeset/217535>
Radar WebKit Bug Importer
Comment 7 2017-05-30 20:19:49 PDT
<rdar://problem/32479658>
Note You need to log in before you can comment on or make changes to this bug.