Bug 172684

Summary:

[WebIDL] @@iterator should only be accessed once when disambiguating a union type

Product:

WebKit

Reporter:

Sam Weinig <sam>

Component:

New Bugs

Assignee:

Sam Weinig <sam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, cdumez, commit-queue, keith_miller, mark.lam, msaboff, saam, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

See Also:

https://bugs.webkit.org/show_bug.cgi?id=172683

Attachments:

Description	Flags
Patch	buildbot: commit-queue-
Archive of layout-test-results from ews126 for ios-simulator-wk2	none
Patch	none

Sam Weinig

Reported 2017-05-27 15:41:54 PDT

[WebIDL] @@iterator should only be accessed once when disambiguating a union type

Attachments
Patch (26.94 KB, patch) 2017-05-27 15:57 PDT, Sam Weinig	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (905.71 KB, application/zip) 2017-05-27 17:26 PDT, Build Bot	no flags	Details
Patch (26.94 KB, patch) 2017-05-27 17:59 PDT, Sam Weinig	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Sam Weinig

Comment 1 2017-05-27 15:57:12 PDT

Created attachment 311425 [details] Patch

Build Bot

Comment 2 2017-05-27 17:26:25 PDT Comment hidden (obsolete)

Comment on attachment 311425 [details] Patch Attachment 311425 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3829266 New failing tests: webrtc/peer-connection-audio-mute.html fast/css/target-fragment-match.html

Build Bot

Comment 3 2017-05-27 17:26:26 PDT Comment hidden (obsolete)

Created attachment 311427 [details] Archive of layout-test-results from ews126 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews126 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Sam Weinig

Comment 4 2017-05-27 17:52:31 PDT

I'm not convinced this patch did that. Seems very unlikely and for it to be iOS only is also suspect.

Sam Weinig

Comment 5 2017-05-27 17:59:02 PDT

Created attachment 311429 [details] Patch

Sam Weinig

Comment 6 2017-05-27 18:00:26 PDT

I should note, this same issue exists for overload disambiguation, and that should eventually be fixed, but I don't know of any overloaded operations that take a sequence as an argument, so it's not observable at present.

Yusuke Suzuki

Comment 7 2017-05-28 18:02:30 PDT

Comment on attachment 311429 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311429&action=review r=me > Source/WebCore/ChangeLog:12 > + the sequence conversion code re-accessed it, which is observable and wrong. Yeah. It reminds me of the implementation of Array.from.

WebKit Commit Bot

Comment 8 2017-05-28 18:31:02 PDT

Comment on attachment 311429 [details] Patch Clearing flags on attachment: 311429 Committed r217529: <http://trac.webkit.org/changeset/217529>

WebKit Commit Bot

Comment 9 2017-05-28 18:31:03 PDT

All reviewed patches have been landed. Closing bug.

Radar WebKit Bug Importer

Comment 10 2017-05-30 20:19:54 PDT

<rdar://problem/32479661>

Note You need to log in before you can comment on or make changes to this bug.