Bug 172664

Summary: JSContext Inspector: Improve the reliability of automatically pausing in auto-attach
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, inspector-bugzilla-changes, joepeck, keith_miller, mark.lam, mattbaker, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
none
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2017-05-26 14:32:48 PDT
Summary: Improve the reliability of automatically pausing in auto-attach Currently when autopause is enabled we trigger a pause, then open the frontend. It is often the case that the frontend perform actions in its initialization that cause us to unpause. Lets defer the autopause pause to after the frontend has initialized. This is after all of the frontend's work and before any user scripts.
Attachments
[PATCH] Proposed Fix (19.91 KB, patch)
2017-05-26 14:44 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
[PATCH] Proposed Fix (20.29 KB, patch)
2017-05-26 14:47 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2017-05-26 14:33:01 PDT
<rdar://problem/32362933>
Joseph Pecoraro
Comment 2 2017-05-26 14:44:45 PDT
Created attachment 311379 [details] [PATCH] Proposed Fix
Joseph Pecoraro
Comment 3 2017-05-26 14:47:48 PDT
Created attachment 311380 [details] [PATCH] Proposed Fix Improved ChangeLog to describe the problem we are solving and why.
Matt Baker
Comment 4 2017-05-26 14:53:13 PDT
Comment on attachment 311380 [details] [PATCH] Proposed Fix r=me
WebKit Commit Bot
Comment 5 2017-05-26 15:57:01 PDT
Comment on attachment 311380 [details] [PATCH] Proposed Fix Clearing flags on attachment: 311380 Committed r217509: <http://trac.webkit.org/changeset/217509>
WebKit Commit Bot
Comment 6 2017-05-26 15:57:03 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.