Bug 172654

Summary: REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Keith Miller <keith_miller>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, commit-queue, keith_miller, msaboff, saam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Local Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch for landing none

Mark Lam
Reported 2017-05-26 12:28:33 PDT
After r217459, we get: ... 2017-05-26 12:15:07.775 testapi[92608:83259983] TEST: "Should not throw an exception when wrapping NSObject and Object has been changed": FAILED ... FAIL: Some tests failed.
Attachments
Patch (1.59 KB, patch)
2017-05-26 15:47 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.73 KB, patch)
2017-05-26 18:54 PDT, Keith Miller 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Keith Miller
Comment 1 2017-05-26 15:47:10 PDT
Created attachment 311386 [details] Patch
Mark Lam
Comment 2 2017-05-26 15:56:27 PDT
Comment on attachment 311386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review r=me with suggestion. > Source/JavaScriptCore/ChangeLog:8 > + Fix the test to make sure we don't not check for an exception. How about rephrasing this as: The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for the opposite condition. This is now fixed.
Keith Miller
Comment 3 2017-05-26 18:45:54 PDT
Comment on attachment 311386 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review >> Source/JavaScriptCore/ChangeLog:8 >> + Fix the test to make sure we don't not check for an exception. > > How about rephrasing this as: > The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for the opposite condition. This is now fixed. I changed it to: "The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for !! the condition. This is now fixed." gotta preserve my pun..
Keith Miller
Comment 4 2017-05-26 18:49:37 PDT
Actually, make that: The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for ! the right condition. This is now fixed.
Keith Miller
Comment 5 2017-05-26 18:54:54 PDT
Created attachment 311402 [details] Patch for landing
WebKit Commit Bot
Comment 6 2017-05-26 19:33:12 PDT
Comment on attachment 311402 [details] Patch for landing Clearing flags on attachment: 311402 Committed r217517: <http://trac.webkit.org/changeset/217517>
WebKit Commit Bot
Comment 7 2017-05-26 19:33:14 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 8 2017-05-30 20:21:09 PDT
<rdar://problem/32479700>
Note You need to log in before you can comment on or make changes to this bug.