Bug 172654

Summary:

REEGRESSION(r217459): testapi fails in JSExportTest's wrapperForNSObjectisObject().

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Keith Miller <keith_miller>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, keith_miller, msaboff, saam, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Local Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch for landing	none

Description Mark Lam 2017-05-26 12:28:33 PDT

After r217459, we get:
...
2017-05-26 12:15:07.775 testapi[92608:83259983] TEST: "Should not throw an exception when wrapping NSObject and Object has been changed": FAILED
...
FAIL: Some tests failed.

Comment 1 Keith Miller 2017-05-26 15:47:10 PDT

Created attachment 311386 [details]
Patch

Comment 2 Mark Lam 2017-05-26 15:56:27 PDT

Comment on attachment 311386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review

r=me with suggestion.

> Source/JavaScriptCore/ChangeLog:8
> +        Fix the test to make sure we don't not check for an exception.

How about rephrasing this as:
The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for the opposite condition.  This is now fixed.

Comment 3 Keith Miller 2017-05-26 18:45:54 PDT

Comment on attachment 311386 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311386&action=review

>> Source/JavaScriptCore/ChangeLog:8
>> +        Fix the test to make sure we don't not check for an exception.
> 
> How about rephrasing this as:
> The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for the opposite condition.  This is now fixed.

I changed it to:

"The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for !! the condition. This is now fixed."

gotta preserve my pun..

Comment 4 Keith Miller 2017-05-26 18:49:37 PDT

Actually, make that:

The test's intent is to assert that an exception has not been thrown (as indicated by the message string), but the test was erroneously checking for ! the right condition. This is now fixed.

Comment 5 Keith Miller 2017-05-26 18:54:54 PDT

Created attachment 311402 [details]
Patch for landing

Comment 6 WebKit Commit Bot 2017-05-26 19:33:12 PDT

Comment on attachment 311402 [details]
Patch for landing

Clearing flags on attachment: 311402

Committed r217517: <http://trac.webkit.org/changeset/217517>

Comment 7 WebKit Commit Bot 2017-05-26 19:33:14 PDT

All reviewed patches have been landed.  Closing bug.

Comment 8 Radar WebKit Bug Importer 2017-05-30 20:21:09 PDT

<rdar://problem/32479700>