Bug 172638

Summary: [CMake] Pass -fdiagnostics-color=always to GCC when building with Ninja
Product: WebKit Reporter: Adrian Perez <aperez>
Component: Tools / TestsAssignee: Adrian Perez <aperez>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, commit-queue, lforschler, mcatanzaro, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Adrian Perez
Reported 2017-05-26 02:33:17 PDT
It would be nice to make GCC generate colored warning/error messages when building with Ninja. In “OptionsCommon.cmake” there is code to enable this for Clang, and it should be possible to do something similar for GCC.
Attachments
Patch (1.91 KB, patch)
2017-05-26 02:36 PDT, Adrian Perez 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2017-05-26 02:36:04 PDT
Created attachment 311346 [details] Patch
Yusuke Suzuki
Comment 2 2017-05-26 02:38:20 PDT
Comment on attachment 311346 [details] Patch r=me, nice
WebKit Commit Bot
Comment 3 2017-05-26 03:16:09 PDT
Comment on attachment 311346 [details] Patch Clearing flags on attachment: 311346 Committed r217485: <http://trac.webkit.org/changeset/217485>
WebKit Commit Bot
Comment 4 2017-05-26 03:16:11 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 5 2017-05-30 20:20:54 PDT
<rdar://problem/32479694>
Note You need to log in before you can comment on or make changes to this bug.