Bug 172638

Summary:

[CMake] Pass -fdiagnostics-color=always to GCC when building with Ninja

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

Tools / Tests

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, commit-queue, lforschler, mcatanzaro, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

Other

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adrian Perez 2017-05-26 02:33:17 PDT

It would be nice to make GCC generate colored warning/error messages
when building with Ninja. In “OptionsCommon.cmake” there is code to
enable this for Clang, and it should be possible to do something
similar for GCC.

Comment 1 Adrian Perez 2017-05-26 02:36:04 PDT

Created attachment 311346 [details]
Patch

Comment 2 Yusuke Suzuki 2017-05-26 02:38:20 PDT

Comment on attachment 311346 [details]
Patch

r=me, nice

Comment 3 WebKit Commit Bot 2017-05-26 03:16:09 PDT

Comment on attachment 311346 [details]
Patch

Clearing flags on attachment: 311346

Committed r217485: <http://trac.webkit.org/changeset/217485>

Comment 4 WebKit Commit Bot 2017-05-26 03:16:11 PDT

All reviewed patches have been landed.  Closing bug.

Comment 5 Radar WebKit Bug Importer 2017-05-30 20:20:54 PDT

<rdar://problem/32479694>