Bug 172633

Summary: Only include DataDetectorsUI headers in iOS
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: PlatformAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, beidson, commit-queue, ddkilzer, ggaren, joepeck
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Disables data detections entirely
none
Patch for landing none

Ryosuke Niwa
Reported 2017-05-25 23:43:39 PDT
Don't always include DataDetectorsUI headers
Attachments
Patch (1.32 KB, patch)
2017-05-25 23:44 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Disables data detections entirely (19.81 KB, patch)
2017-05-26 23:41 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Patch for landing (20.17 KB, patch)
2017-05-30 11:31 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2017-05-25 23:44:50 PDT
Created attachment 311339 [details] Patch
David Kilzer (:ddkilzer)
Comment 2 2017-05-26 20:29:01 PDT
Comment on attachment 311339 [details] Patch r=me
Ryosuke Niwa
Comment 3 2017-05-26 23:41:59 PDT
Created attachment 311416 [details] Disables data detections entirely
Ryosuke Niwa
Comment 4 2017-05-26 23:42:48 PDT
<rdar://problem/22739993>
David Kilzer (:ddkilzer)
Comment 5 2017-05-30 11:22:03 PDT
Comment on attachment 311416 [details] Disables data detections entirely View in context: https://bugs.webkit.org/attachment.cgi?id=311416&action=review r=me > Source/WTF/wtf/Platform.h:552 > #define HAVE_AVKIT 1 > #define HAVE_PARENTAL_CONTROLS 1 > +#define ENABLE_DATA_DETECTION 1 Nit: Please alphabetize by full macro name (so ENABLE_* would come before HAVE_*). > Source/WebKit2/UIProcess/API/Cocoa/WKWebView.mm:56 > +#if ENABLE(DATA_DETECTION) > #import "WKDataDetectorTypesInternal.h" > +#endif Are we still putting these in a separate section after the default list of #import statements? > Source/WebKit2/WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInRangeHandle.mm:34 > +#if ENABLE(DATA_DETECTION) > #import "WKDataDetectorTypesInternal.h" > +#endif Move to after default list of #import statements?
Ryosuke Niwa
Comment 6 2017-05-30 11:31:11 PDT
Created attachment 311521 [details] Patch for landing
Ryosuke Niwa
Comment 7 2017-05-30 11:32:09 PDT
Comment on attachment 311521 [details] Patch for landing Wait for EWS.
Ryosuke Niwa
Comment 8 2017-05-30 11:32:16 PDT
Thanks for the review!
WebKit Commit Bot
Comment 9 2017-05-30 14:54:56 PDT
Comment on attachment 311521 [details] Patch for landing Clearing flags on attachment: 311521 Committed r217580: <http://trac.webkit.org/changeset/217580>
WebKit Commit Bot
Comment 10 2017-05-30 14:54:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.