Summary: | Acid3 test 80 (linktest onload didn't fire) fails on reload but passes on first run | ||
---|---|---|---|
Product: | WebKit | Reporter: | Matt Lilek <dev+webkit> |
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | CC: | darin, eric, ian, webkit |
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | Mac | ||
OS: | OS X 10.5 | ||
URL: | http://acid3.acidtests.org/ | ||
Bug Depends on: | |||
Bug Blocks: | 17064 |
Description
Matt Lilek
2008-02-09 14:33:27 PST
Webkit r30109. Tens of Acid3 test runs and I haven't notice 79/100 score at all. I've seen this; we need to investigate. It never seems to pass for me. Maybe if I started with an empty cache. Checked the Acid3 test again (it was changed a little - we pass only 79/100 now, red cat displays now). On the first run the test 80 failed (78/100). After reload the test passed (79/100). This and bug 16770 refer to the same Acid3 failure. Which is the real cause, I'm not sure. The issue relies on onload so it turns my attention to behavior reported in bug 15137 or maybe in bug 14693. I believe the reason this test fails on reload may be that on reload the frame gets a new src attribute, but reload simply reloads the old URL. Firefox 2 fails the same way (I didn't try a Firefox 3 beta), and it's possible this is a feature, not a bug. When I wrote the regression test LayoutTests/fast/history/subframe-is-visited.html I worked around this by giving the frame a new name each time. It's possible Acid3 should be modified to do the same thing. Or maybe this truly is a bug. Hmm, after saying all that, I tested and with my latest fix, this seems to work even on reload. I'm going to say FIXED for this bug. The script manually changes the src="" during the test, so it shouldn't matter if reload reloads the old URI. (In reply to comment #9) > The script manually changes the src="" during the test, so it shouldn't matter > if reload reloads the old URI. Yes, I realize that. But when I tried a simple test case, the page that manually changed the src of the iframe element did not load that new src on either Safari or Firefox. I know that sounds crazy. Obviously I didn't understand the issue thoroughly since I can't explain it right now. But there's something unusual going on with frame reloading and dynamic changes to the iframe src attribute, in both browsers. |