Bug 172593

Summary: [css-align] Fixed errors in the CSS parsing tests of the "place-XXX" shorthands
Product: WebKit Reporter: Javier Fernandez <jfernandez>
Component: CSSAssignee: Javier Fernandez <jfernandez>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jfernandez, rego, svillar, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Javier Fernandez
Reported 2017-05-25 08:58:29 PDT
I found out some undefined and repeated CSS classes, which lead to some cases not being verified properly.
Attachments
Patch (3.72 KB, patch)
2017-05-25 09:03 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Patch (3.68 KB, patch)
2017-05-25 10:07 PDT, Javier Fernandez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Javier Fernandez
Comment 1 2017-05-25 09:03:33 PDT
Created attachment 311225 [details] Patch
Manuel Rego Casasnovas
Comment 2 2017-05-25 09:34:56 PDT
Comment on attachment 311225 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311225&action=review Thanks for fixing this. > LayoutTests/ChangeLog:8 > + Fixed errors in some of the test cases. Nit: this line is not saying anything else than the title, so not really needed. :-)
Javier Fernandez
Comment 3 2017-05-25 10:07:55 PDT
Created attachment 311237 [details] Patch
WebKit Commit Bot
Comment 4 2017-05-25 10:40:52 PDT
Comment on attachment 311237 [details] Patch Clearing flags on attachment: 311237 Committed r217435: <http://trac.webkit.org/changeset/217435>
WebKit Commit Bot
Comment 5 2017-05-25 10:40:54 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 6 2017-05-30 20:24:35 PDT
<rdar://problem/32479787>
Note You need to log in before you can comment on or make changes to this bug.