Bug 172593 - [css-align] Fixed errors in the CSS parsing tests of the "place-XXX" shorthands
Summary: [css-align] Fixed errors in the CSS parsing tests of the "place-XXX" shorthands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Javier Fernandez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2017-05-25 08:58 PDT by Javier Fernandez
Modified: 2017-05-30 20:24 PDT (History)
5 users (show)

See Also:


Attachments
Patch (3.72 KB, patch)
2017-05-25 09:03 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (3.68 KB, patch)
2017-05-25 10:07 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2017-05-25 08:58:29 PDT
I found out some undefined and repeated CSS classes, which lead to some cases not being verified properly.
Comment 1 Javier Fernandez 2017-05-25 09:03:33 PDT
Created attachment 311225 [details]
Patch
Comment 2 Manuel Rego Casasnovas 2017-05-25 09:34:56 PDT
Comment on attachment 311225 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311225&action=review

Thanks for fixing this.

> LayoutTests/ChangeLog:8
> +        Fixed errors in some of the test cases.

Nit: this line is not saying anything else than the title, so not really needed. :-)
Comment 3 Javier Fernandez 2017-05-25 10:07:55 PDT
Created attachment 311237 [details]
Patch
Comment 4 WebKit Commit Bot 2017-05-25 10:40:52 PDT
Comment on attachment 311237 [details]
Patch

Clearing flags on attachment: 311237

Committed r217435: <http://trac.webkit.org/changeset/217435>
Comment 5 WebKit Commit Bot 2017-05-25 10:40:54 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Radar WebKit Bug Importer 2017-05-30 20:24:35 PDT
<rdar://problem/32479787>