| Summary: | [css-grid] Add support for orthogonal positioned grid items | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||
| Component: | Layout and Rendering | Assignee: | Manuel Rego Casasnovas <rego> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | bfulgham, buildbot, commit-queue, jfernandez, rego, simon.fraser, svillar, webkit-bug-importer, zalan | ||||||
| Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| See Also: | https://bugs.chromium.org/p/chromium/issues/detail?id=639873 | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 60731 | ||||||||
| Attachments: |
|
||||||||
|
Description
Manuel Rego Casasnovas
2017-05-25 07:54:39 PDT
Created attachment 311221 [details]
Patch
Comment on attachment 311221 [details]
Patch
The patch looks fine, but I have concerns about the tests design and how we could verify the result visually; manually comparing the test and its expected html could be difficult if the differences are small.
(In reply to Javier Fernandez from comment #2) > Comment on attachment 311221 [details] > Patch > > The patch looks fine, but I have concerns about the tests design and how we > could verify the result visually; manually comparing the test and its > expected html could be difficult if the differences are small. I'm just importing the tests here, so if we want to improve them we should probably do it in a follow-up patch or directly on WPT. The tests are expected to be run automatically, but even manually the smallest difference is 5px (which is not so small I believe). Comment on attachment 311221 [details] Patch Attachment 311221 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3814736 New failing tests: webrtc/peer-connection-audio-mute.html Created attachment 311233 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2
The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5
Comment on attachment 311221 [details] Patch Clearing flags on attachment: 311221 Committed r217486: <http://trac.webkit.org/changeset/217486> All reviewed patches have been landed. Closing bug. |