Bug 172580

Summary:

Use a typedef for SVG resource mode flags union

Product:

WebKit

Reporter:

Simon Fraser (smfr) <simon.fraser>

Component:

New Bugs

Assignee:

Simon Fraser (smfr) <simon.fraser>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, dino, sabouhallawa, sam, simon.fraser, thorton, webkit-bug-importer, ysuzuki

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from ews124 for ios-simulator-wk2	none
Patch	none

Simon Fraser (smfr)

Reported 2017-05-24 22:07:39 PDT

Use a typedef for SVG resource mode flags union

Attachments
Patch (22.20 KB, patch) 2017-05-24 22:09 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Archive of layout-test-results from ews124 for ios-simulator-wk2 (11.05 MB, application/zip) 2017-05-25 00:42 PDT, Build Bot	no flags	Details
Patch (46.21 KB, patch) 2017-05-25 17:59 PDT, Simon Fraser (smfr)	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Simon Fraser (smfr)

Comment 1 2017-05-24 22:09:45 PDT

Created attachment 311196 [details] Patch

Build Bot

Comment 2 2017-05-25 00:42:22 PDT

Comment on attachment 311196 [details] Patch Attachment 311196 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/3811353 New failing tests: http/tests/cache/cancel-during-revalidation-succeeded.html

Build Bot

Comment 3 2017-05-25 00:42:24 PDT

Created attachment 311209 [details] Archive of layout-test-results from ews124 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews124 Port: ios-simulator-wk2 Platform: Mac OS X 10.12.5

Sam Weinig

Comment 4 2017-05-25 08:38:54 PDT

Comment on attachment 311196 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311196&action=review > Source/WebCore/rendering/svg/RenderSVGResource.h:48 > +typedef unsigned RenderSVGResourceMode; Maybe use OptionSet<RenderSVGResourceModes> instead. If you want to keep it an unsigned, I would recommend using a type alias instead: using RenderSVGResourceMode = unsigned; It's not substantially different, just the syntax we have been moving toward, since it supports things like templated type aliases.

Simon Fraser (smfr)

Comment 5 2017-05-25 17:59:27 PDT

Created attachment 311322 [details] Patch

Sam Weinig

Comment 6 2017-05-25 18:01:01 PDT

Comment on attachment 311322 [details] Patch Nice.

WebKit Commit Bot

Comment 7 2017-05-25 18:31:09 PDT

Comment on attachment 311322 [details] Patch Clearing flags on attachment: 311322 Committed r217463: <http://trac.webkit.org/changeset/217463>

WebKit Commit Bot

Comment 8 2017-05-25 18:31:10 PDT

All reviewed patches have been landed. Closing bug.