Bug 172577

Summary: Syncing script shouldn't schedule a build request when there is a build from another test group in progress
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Perf DashboardAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, dewei_zhu, rniwa, slewis, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Fixes the bug none

Ryosuke Niwa
Reported 2017-05-24 21:16:03 PDT
Apparently the syncing script can end up scheduling a new build request for a test group when there is an in-progress build request from another test group.
Attachments
Fixes the bug (13.69 KB, patch)
2017-05-24 22:09 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2017-05-24 21:16:33 PDT
<rdar://problem/32395049>
Ryosuke Niwa
Comment 2 2017-05-24 21:44:04 PDT
When a buildbot gets restarted, it'd re-schedule the currently running build. This can result in multiple builds to be pending simultaneously. The real problem here is that sync-buildbot.js couldn't recover from this state even through I explicitly add a test case for it because the test case itself was broken.
Ryosuke Niwa
Comment 3 2017-05-24 22:09:38 PDT
Created attachment 311195 [details] Fixes the bug
Ryosuke Niwa
Comment 4 2017-05-25 14:10:11 PDT
Comment on attachment 311195 [details] Fixes the bug Clearing flags on attachment: 311195 Committed r217448: <http://trac.webkit.org/changeset/217448>
Ryosuke Niwa
Comment 5 2017-05-25 14:10:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.