Bug 172568

Summary: [CMake] Consolidate CMake code related to Cairo
Product: WebKit Reporter: Don Olmstead <don.olmstead>
Component: Tools / TestsAssignee: Don Olmstead <don.olmstead>
Status: RESOLVED FIXED    
Severity: Normal CC: achristensen, buildbot, commit-queue, csaavedra, lforschler, mcatanzaro, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Don Olmstead
Reported 2017-05-24 18:02:32 PDT
Centralize Cairo cmake code for sharing between ports.
Attachments
Patch (13.30 KB, patch)
2017-05-24 18:09 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Patch (13.30 KB, patch)
2017-05-24 18:17 PDT, Don Olmstead 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Don Olmstead
Comment 1 2017-05-24 18:09:36 PDT
Created attachment 311174 [details] Patch Adds a Cairo.cmake file which unifies the cairo sections of GTK, WinCairo, and WPE. Adds if checks in Gstreamer and image decoder cmake files where applicable. Harfbuzz sources are left unchanged. Another patch will be for freetype, harfbuzz and fontconfig path. Exposes USE_CAIRO to the build with WinCairo so any references there are removed. Compiled successfully on WinCairo.
Build Bot
Comment 2 2017-05-24 18:11:26 PDT
Attachment 311174 [details] did not pass style-queue: ERROR: Source/WebCore/platform/Cairo.cmake:8: No trailing spaces [whitespace/trailing] [5] ERROR: Source/WebCore/platform/Cairo.cmake:9: There should be no empty line between "platform/graphics/cairo/BackingStoreBackendCairoImpl.cpp" and "platform/graphics/cairo/CairoUtilities.cpp". [list/emptyline] [5] Total errors found: 2 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Don Olmstead
Comment 3 2017-05-24 18:17:56 PDT
Created attachment 311175 [details] Patch Fixing style
Michael Catanzaro
Comment 4 2017-05-24 19:05:58 PDT
Nice!
WebKit Commit Bot
Comment 5 2017-05-24 19:16:36 PDT
Comment on attachment 311175 [details] Patch Clearing flags on attachment: 311175 Committed r217404: <http://trac.webkit.org/changeset/217404>
WebKit Commit Bot
Comment 6 2017-05-24 19:16:38 PDT
All reviewed patches have been landed. Closing bug.
Claudio Saavedra
Comment 7 2017-05-25 02:58:09 PDT
This broke WPE. Here's the build fix: http://trac.webkit.org/changeset/217410
Don Olmstead
Comment 8 2017-05-25 09:50:26 PDT
(In reply to Claudio Saavedra from comment #7) > This broke WPE. Here's the build fix: > > http://trac.webkit.org/changeset/217410 Ugh sorry! EWS for WPE coming anytime soon?
Radar WebKit Bug Importer
Comment 9 2017-05-30 20:25:26 PDT
<rdar://problem/32479802>
Note You need to log in before you can comment on or make changes to this bug.