Bug 172554

Summary: [WK1] iframes in layer-backed NSViews are not cleared between successive draws
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Needs tests
none
WIP
none
WIP
none
WIP
none
Patch
none
Patch
simon.fraser: review+
Patch for committing commit-queue: commit-queue-

Description Myles C. Maxfield 2017-05-24 13:02:01 PDT 
Update WebHTMLView to match AppKit's layout
Comment 1 Myles C. Maxfield 2017-05-24 13:02:24 PDT 
Created attachment 311147 [details]
Needs tests
Comment 2 Myles C. Maxfield 2017-05-24 13:02:56 PDT 
<rdar://problem/31274603>
Comment 3 Myles C. Maxfield 2017-05-24 13:18:47 PDT 
<rdar://problem/31247133>
Comment 4 Myles C. Maxfield 2017-05-24 17:08:18 PDT 
Created attachment 311167 [details]
WIP
Comment 5 Simon Fraser (smfr) 2017-05-24 17:14:21 PDT 
Comment on attachment 311167 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=311167&action=review

> Source/WebKit/mac/ChangeLog:3
> +        Update WebHTMLView to match AppKit's layout

This title should say something about double-drawing of iframe in layer-backed WebViews
Comment 6 Myles C. Maxfield 2017-05-25 14:44:48 PDT 
Created attachment 311295 [details]
WIP
Comment 7 Myles C. Maxfield 2017-05-25 14:46:12 PDT 
Created attachment 311296 [details]
WIP
Comment 8 Myles C. Maxfield 2017-05-25 15:15:13 PDT 
Created attachment 311299 [details]
Patch
Comment 9 Myles C. Maxfield 2017-05-25 15:16:08 PDT 
Created attachment 311300 [details]
Patch
Comment 10 Simon Fraser (smfr) 2017-05-25 15:18:55 PDT 
Comment on attachment 311300 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311300&action=review

> Tools/DumpRenderTree/TestOptions.mm:99
> +bool TestOptions::webViewCompatible(const TestOptions& other) const

Myabe webViewIsCompatibleWithOptions()
Comment 11 Myles C. Maxfield 2017-05-25 16:54:08 PDT 
Created attachment 311318 [details]
Patch for committing
Comment 12 WebKit Commit Bot 2017-05-25 17:38:51 PDT 
Comment on attachment 311318 [details]
Patch for committing

Rejecting attachment 311318 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 311318, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

ChangeLog entry in LayoutTests/ChangeLog contains OOPS!.

Full output: http://webkit-queues.webkit.org/results/3818297
Comment 13 Myles C. Maxfield 2017-05-25 17:43:03 PDT 
Committed r217461: <http://trac.webkit.org/changeset/217461>