Bug 172524

Summary: Resource Load Statistics: Change grandfathering default to one hour
Product: WebKit Reporter: John Wilander <wilander>
Component: WebKit2Assignee: John Wilander <wilander>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, cdumez, commit-queue, dbates, japhet, webkit-bug-importer, wilander
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Description John Wilander 2017-05-23 14:17:44 PDT
We should only grandfather website data records for one hour to start with. If more is needed we can bump it up again.
Comment 1 Radar WebKit Bug Importer 2017-05-23 14:18:22 PDT
<rdar://problem/32360462>
Comment 2 John Wilander 2017-05-23 14:22:04 PDT
Created attachment 311051 [details]
Patch
Comment 3 Brent Fulgham 2017-05-23 17:51:54 PDT
Comment on attachment 311051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=311051&action=review

r=me

> Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152
> +    WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600);

Weird that we can't use "grandfatheringTime" here, instead of a magic number.
Comment 4 John Wilander 2017-05-24 10:08:39 PDT
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 311051 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=311051&action=review
> 
> r=me
> 
> > Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152
> > +    WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600);
> 
> Weird that we can't use "grandfatheringTime" here, instead of a magic number.

Thanks for the review!

grandfatheringTime in ResourceLoadStatisticsStore.cpp is the variable that's changed so we'd have to introduce a constant.
Comment 5 WebKit Commit Bot 2017-05-24 10:37:00 PDT
Comment on attachment 311051 [details]
Patch

Clearing flags on attachment: 311051

Committed r217372: <http://trac.webkit.org/changeset/217372>
Comment 6 WebKit Commit Bot 2017-05-24 10:37:01 PDT
All reviewed patches have been landed.  Closing bug.