Summary: | Resource Load Statistics: Change grandfathering default to one hour | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | John Wilander <wilander> | ||||
Component: | WebKit2 | Assignee: | John Wilander <wilander> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | bfulgham, buildbot, cdumez, commit-queue, dbates, japhet, webkit-bug-importer, wilander | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
John Wilander
2017-05-23 14:17:44 PDT
Created attachment 311051 [details]
Patch
Comment on attachment 311051 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311051&action=review r=me > Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152 > + WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600); Weird that we can't use "grandfatheringTime" here, instead of a magic number. (In reply to Brent Fulgham from comment #3) > Comment on attachment 311051 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=311051&action=review > > r=me > > > Source/WebKit2/UIProcess/WebResourceLoadStatisticsManager.cpp:152 > > + WebCore::ResourceLoadObserver::sharedObserver().setGrandfatheringTime(3600); > > Weird that we can't use "grandfatheringTime" here, instead of a magic number. Thanks for the review! grandfatheringTime in ResourceLoadStatisticsStore.cpp is the variable that's changed so we'd have to introduce a constant. Comment on attachment 311051 [details] Patch Clearing flags on attachment: 311051 Committed r217372: <http://trac.webkit.org/changeset/217372> All reviewed patches have been landed. Closing bug. |