Bug 172520

Summary: checkGPUStatus needs to exercise instancing calls
Product: WebKit Reporter: Dean Jackson <dino>
Component: New BugsAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, cdumez, esprehn+autocc, graouts, gyuyoung.kim, kondapallykalyan, noam, simon.fraser
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch bfulgham: review+

Dean Jackson
Reported 2017-05-23 12:42:42 PDT
checkGPUStatus needs to exercise instancing calls
Attachments
Patch (20.81 KB, patch)
2017-05-23 12:49 PDT, Dean Jackson 		bfulgham: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dean Jackson
Comment 1 2017-05-23 12:49:54 PDT
Created attachment 311040 [details] Patch
Simon Fraser (smfr)
Comment 2 2017-05-23 12:56:44 PDT
Comment on attachment 311040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311040&action=review > Source/WebCore/html/canvas/WebGLRenderingContextBase.h:361 > + WEBCORE_EXPORT void setFailNextGPUStatusCheck(); Maybe add "ForTesting" to the name here and elsewhere, to make it a bit less mysterious.
Brent Fulgham
Comment 3 2017-05-23 13:24:11 PDT
Comment on attachment 311040 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=311040&action=review Looks good! I mostly commented just to test my local WebKit build. :-) r=me. > Source/WebCore/platform/graphics/GraphicsContext3D.h:1441 > + unsigned m_statusCheckCount { 0 }; It seems like this could overflow if you status check counted enough times. But maybe you reset later? > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:65 > +static const unsigned statusCheckThreshold = 5; I never know when we should be using constexpr. Here? No? > Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:652 > + m_statusCheckCount = (m_statusCheckCount + 1) % statusCheckThreshold; So this resets every statusCheckThreshold counts. Since that's currently set to 5, unsigned might be bigger than we need, but seems fine.
Dean Jackson
Comment 4 2017-05-23 13:50:32 PDT
Committed r217298: <http://trac.webkit.org/changeset/217298>
Note You need to log in before you can comment on or make changes to this bug.